RAD-377: Search by report template license #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivange94
requested changes
Oct 21, 2016
| @Autowired | ||
| private MrrtReportTemplateService mrrtReportTemplateService; | ||
|
|
||
| SearchQuery searchQuery = new SearchQuery.Builder("Allows you to search for MrrtReportTemplate's by title") | ||
| .withOptionalParameters(new String[] { REQUEST_PARAM_TITLE, REQUEST_PARAM_PUBLISHER, REQUEST_PARAM_TOTAL_COUNT }) | ||
| .withOptionalParameters(new String[] { REQUEST_PARAM_TITLE, REQUEST_PARAM_PUBLISHER, REQUEST_PARAM_TOTAL_COUNT, | ||
| REQUEST_PARAM_LICENSE }) | ||
| .build(); |
There was a problem hiding this comment.
can you please put REQUEST_PARAM_TOTAL_COUNT at the end of the list?
teleivo
requested changes
Nov 15, 2016
| assertThat(templates.size(), is(1)); | ||
| assertThat(templates.get(0) | ||
| .getDcTermsLicense(), | ||
| is("General Public License")); |
There was a problem hiding this comment.
why dont you use your constant EXISTING_TEMPLATE_LICENSE ?
|
|
||
| assertNotNull(licenses); | ||
| assertThat(licenses.size(), is(2)); | ||
| assertTrue(licenses.contains("Mozilla Public License")); |
There was a problem hiding this comment.
use your constants instead of the string literals and you should be able to use matchers that test that these two string constants are in the list without asserTrue.
|
@achabill are you still working on this? |
RAD-377: Request changes RAD-377: Request changes PR openmrs#498 - using string constant - List matchers without assertTrue
teleivo
approved these changes
Nov 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RAD-377: Search by report template license
Description
Provided a Java API + REST API for search of Mrrt report templates via the MrrtReportTemplate.dctermsLicense.
Related Issue
see https://issues.openmrs.org/browse/RAD-377
Checklist:
git pull --rebase upstream master.mvn clean packageright before creating this pull request andadded all formatting changes to my commit.