Updating concepts to CIEL 2.1_20190227 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkayiwa, these are all the significant changes made as part of the latest ciel release |
|
They do not look that many. Are they? |
|
There were over 2000 changes but were all minor changes like date changes etc. As you had mentioned in the previous pr reviews, I ignored these changes. Finally what remains is this |
|
@dkayiwa , that being said , I'm more worried about what I've mentioned here : https://talk.openmrs.org/t/reference-application-2-9-testing/21389/44?u=reubenv |
reubenvarghese1
force-pushed
the
updateciel
branch
from
5ba9f10
to
7994afb
Compare
|
@dkayiwa I have squashed the previous commits and ensured that 165095 is added back. Thanks to @rkorytkowski who solved it by adding it individually as per this post |
|
@reubenvarghese1 did you test by running the module and confirm that the concept shows up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating concepts to CIEL 2.1_20190227