RESTWS-726: Return diagnoses with an encounter

[dsurrao]

https://issues.openmrs.org/browse/RESTWS-726

[coveralls]

Coverage increased (+0.03%) to 42.942% when pulling 0f0ee51 on dsurrao:master into b77134b on openmrs:master.

[mogoodrich]

Looks good, merging in...

[wluyima]

Is it intentional not to include these among creatable/updatable properties?

[mogoodrich]

Good question @wluyima ... this ticket was just about making sure that diagnoses were returned as part of an encounter when when requesting an encounter since we noticed this was missing. We didn't really give any thought to the create/update part, but I think it is likely we want to make diagnoses createable and updateable, but we can handle this under a separate ticket.

[wluyima]

I think it should happen as part of the same ticket, it's how we have always handled the addition of new resources.
The issue is that the Sync2 module needs to sync encounters, it means we have to exclude diagnoses from an encounter when syncing which is not right. It is a trivial task anyways to add the property to creatable/updatable properties

[mogoodrich]

That makes sense @wluyima, I can add this sometime next week. (Trivial to add, I agree, but I want to add a test or two around it as well.