Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.8 submodule-RESTWS-741. I deleted the 1.8 submodule and crea… #571

Closed
wants to merge 1 commit into from

Conversation

suubi-joshua
Copy link

…ted similar classes in the 1.9 submodule that has the same code as the classes I deleted. I change the supported versions on all resources to exclude 1.8.x versions

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-741

Checklist: I completed these to help reviewers :)

  • [ x] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [ x] I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

…ted similar classes in the 1.9 submodule that has the same code as the classes I deleted. I change the supported versions on all resources to exclude 1.8.x versions
@njiddasalifu
Copy link

Hi, have you noticed the install dependency failed under checks?
I think you should take a look at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants