updated with single div and improved test

openmrs · Sep 30, 2021 · 9a9a1cf · 9a9a1cf
1 parent ceb7f74
commit 9a9a1cf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/apps/concepts/components/NamesTable.tsx b/src/apps/concepts/components/NamesTable.tsx
@@ -47,8 +47,7 @@ const useStyles = makeStyles((theme: Theme) =>
       minWidth: "150px"
     },
     menuItemSynonym: {
-      color: "#A9A9A9",
-      fontStyle: "italic"
+      opacity: 0.38
     }
   })
 );
@@ -148,13 +147,15 @@ const NamesTable: React.FC<Props> = ({
                       >
                         {NAME_TYPES.map(nameType => (
                           <MenuItem key={nameType.value} value={nameType.value}>
-                            {nameType.label.includes("Synonym") ? (
-                              <div className={classes.menuItemSynonym}>
-                                ({nameType.label})
-                              </div>
-                            ) : (
-                              <div>{nameType.label}</div>
-                            )}
+                            <div
+                              className={
+                                nameType.label === "Synonym"
+                                  ? classes.menuItemSynonym
+                                  : undefined
+                              }
+                            >
+                              ({nameType.label})
+                            </div>
                           </MenuItem>
                         ))}
                       </Field>

diff --git a/src/utils/constants.ts b/src/utils/constants.ts
@@ -268,8 +268,8 @@ export const DATA_TYPES: string[] = [
 ];
 
 export const NAME_TYPES: { [key: string]: string }[] = [
-  { value: "null", label: "Synonym" }, // value here should be null but inputs html can't handle null as a value
   { value: "FULLY_SPECIFIED", label: "Fully Specified" },
+  { value: "null", label: "Synonym" }, // value here should be null but inputs html can't handle null as a value
   { value: "SHORT", label: "Short" },
   { value: "INDEX_TERM", label: "Index Term" }
 ];