Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCLOMRS-41: Fix authentication #37

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

hadijahkyampeire
Copy link
Collaborator

JIRA TICKET NAME:

OCLOMRS-41: Fix authentication

Summary:

This adds to the protection of URLs so that if a user is logged in they should always go to the dashboard when they open the app.

@coveralls
Copy link

coveralls commented Jun 20, 2018

Pull Request Test Coverage Report for Build 183

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 69.86%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Auth/index.jsx 2 3 66.67%
Totals Coverage Status
Change from base Build 176: 1.8%
Covered Lines: 267
Relevant Lines: 354

💛 - Coveralls

Copy link
Contributor

@shakirandagire shakirandagire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@EleisonC EleisonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mwaz mwaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@emasys emasys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fix access to urls
@dkayiwa dkayiwa merged commit 7639c23 into openmrs:master Jun 21, 2018
kirity-mahanty added a commit that referenced this pull request Sep 30, 2020
…ncepts in a Source (#614)

* Tarun, Kirity | OCLOMRS-868 | MOBN-1390 | View the total number of concepts in a Source (#27)

* Tarun | Kirity | MOBN-1390 | View the total number of concepts in a Source

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Unit tests

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Added active and retired concepts

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Refactored code

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Added unit tests

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Refactored code

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated title for concept summary block

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated component name

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated component name in test file

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated viewSourcePage snapshot test to include concept summary

Co-authored-by: Kirity Mahanty <kirity.mahanty@thoughtworks.com>

* Tarun, Bindu | OCLOMRS-868 | MOBN-1453 | Fix data discrepancy in Concept Summary Section for Active and Total Number of Concepts (#37)

* Tarun, Bindu | MOBN-1453 | Fix concept summary details in source details page

* Tarun,Bindu | MOBN-1453 | Corrected Typo in actiontype

* Tarun, Bindu | MOBN-1453 | Refactored code and added unit tests

* Tarun, Bindu | MOBN-1453 | Add test cases for get activeConcepts api and viewSourcePage container

* Tarun, Bindu | MOBN-1453 | Fix the broken UI for longtext for supported locale, owner_url

* Tarun, Bindu | MOBN-1453 | Remove multiline prop for supported locale field in both Dictionary Form and Source Form

* Tarun | MOBN-1453 | Handled feedback changes

* Tarun | MOBN-1453 | Refactored retrive concepts api call

* Tarun | MOBN-1453 | Handle feedback changes

Co-authored-by: tarunkumar-tw <tarunkumar.s@thoughtworks.com>

Co-authored-by: Kirity Mahanty <kirity.mahanty@thoughtworks.com>
Co-authored-by: Himabindu T <tbindu@thoughtworks.com>
kirity-mahanty added a commit that referenced this pull request Sep 30, 2020
…ilable in a Source (#615)

* Tarun, Kirity | OCLOMRS-868 | MOBN-1390 | View the total number of concepts in a Source (#27)

* Tarun | Kirity | MOBN-1390 | View the total number of concepts in a Source

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Unit tests

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Added active and retired concepts

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Refactored code

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Added unit tests

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Refactored code

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated title for concept summary block

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated component name

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated component name in test file

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated viewSourcePage snapshot test to include concept summary

Co-authored-by: Kirity Mahanty <kirity.mahanty@thoughtworks.com>

* Tarun, Bindu | OCLOMRS-868 | MOBN-1453 | Fix data discrepancy in Concept Summary Section for Active and Total Number of Concepts (#37)

* Tarun, Bindu | MOBN-1453 | Fix concept summary details in source details page

* Tarun,Bindu | MOBN-1453 | Corrected Typo in actiontype

* Tarun, Bindu | MOBN-1453 | Refactored code and added unit tests

* Tarun, Bindu | MOBN-1453 | Add test cases for get activeConcepts api and viewSourcePage container

* Tarun, Bindu | MOBN-1453 | Fix the broken UI for longtext for supported locale, owner_url

* Tarun, Bindu | MOBN-1453 | Remove multiline prop for supported locale field in both Dictionary Form and Source Form

* Tarun | MOBN-1453 | Handled feedback changes

* Tarun | MOBN-1453 | Refactored retrive concepts api call

* Tarun | MOBN-1453 | Handle feedback changes

Co-authored-by: tarunkumar-tw <tarunkumar.s@thoughtworks.com>

* Vinisha, Tarun | OCLOMRS-867 | MOBN-1459 | View the list of concepts that are available in a Source

Co-authored-by: tarunkumar-tw <58736833+tarunkumar-tw@users.noreply.github.com>
Co-authored-by: Kirity Mahanty <kirity.mahanty@thoughtworks.com>
Co-authored-by: Himabindu T <tbindu@thoughtworks.com>
Co-authored-by: tarunkumar-tw <tarunkumar.s@thoughtworks.com>
Co-authored-by: Kirity Mahanty <58568821+kirity-mahanty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants