Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCLOMRS-40: Redesign sources page user interface #27

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

emasys
Copy link
Contributor

@emasys emasys commented Jun 8, 2018

JIRA TICKET NAME:

Redesign sources page user interface

Summary:

Redesign the source cards and remove the sort button from the search bar

Copy link
Contributor

@EleisonC EleisonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mwaz mwaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shakirandagire shakirandagire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkayiwa dkayiwa merged commit 32afaff into openmrs:master Jun 8, 2018
hadijahkyampeire pushed a commit to hadijahkyampeire/openmrs-ocl-client that referenced this pull request Jun 12, 2018
OCLOMRS-40: redesign sources page user interface (openmrs#27)
hadijahkyampeire pushed a commit to hadijahkyampeire/openmrs-ocl-client that referenced this pull request Jun 12, 2018
…n"" (openmrs#25)

* Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)"

This reverts commit 20ecf9b.

* Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)"

This reverts commit f2f81b0.

* Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)"

This reverts commit 5fcea0d.

* Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)"

This reverts commit f6d6d28.

* Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)"

This reverts commit f6be69c.

OCLOMRS-35: display sources and enable searching (openmrs#26)

OCLOMRS-40: redesign sources page user interface (openmrs#27)
hadijahkyampeire pushed a commit to hadijahkyampeire/openmrs-ocl-client that referenced this pull request Jun 12, 2018
…better code" (openmrs#22)" (openmrs#23)

This reverts commit 5fcea0d.

Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)

* Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)"

This reverts commit f2f81b0.

* Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)"

This reverts commit 5fcea0d.

* Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)"

This reverts commit f6d6d28.

Revert "Revert "OCLOMRS-17: Protect routes that require authentication"" (openmrs#25)

* Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)"

This reverts commit 20ecf9b.

* Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)"

This reverts commit f2f81b0.

* Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)"

This reverts commit 5fcea0d.

* Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)"

This reverts commit f6d6d28.

* Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)"

This reverts commit f6be69c.

OCLOMRS-35: display sources and enable searching (openmrs#26)

OCLOMRS-40: redesign sources page user interface (openmrs#27)
hadijahkyampeire pushed a commit to hadijahkyampeire/openmrs-ocl-client that referenced this pull request Jun 12, 2018
…ode" (openmrs#22)

* Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)"

This reverts commit f6d6d28.

* Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)"

This reverts commit f6be69c.

* Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)"

This reverts commit a0444d4.

* Revert "OCLOMRS-29:Restructure app to improve code maintainability (openmrs#19)"

This reverts commit e77aa4d.

* Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code (openmrs#17)"

This reverts commit 7e68e2f.

Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)

This reverts commit 5fcea0d.

Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)

* Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)"

This reverts commit f2f81b0.

* Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)"

This reverts commit 5fcea0d.

* Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)"

This reverts commit f6d6d28.

Revert "Revert "OCLOMRS-17: Protect routes that require authentication"" (openmrs#25)

* Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)"

This reverts commit 20ecf9b.

* Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)"

This reverts commit f2f81b0.

* Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)"

This reverts commit 5fcea0d.

* Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)"

This reverts commit f6d6d28.

* Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)"

This reverts commit f6be69c.

OCLOMRS-35: display sources and enable searching (openmrs#26)

OCLOMRS-40: redesign sources page user interface (openmrs#27)
hadijahkyampeire pushed a commit to hadijahkyampeire/openmrs-ocl-client that referenced this pull request Jun 14, 2018
hadijahkyampeire pushed a commit to hadijahkyampeire/openmrs-ocl-client that referenced this pull request Jun 14, 2018
…n"" (openmrs#25)

* Revert "Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability"" (openmrs#24)"

This reverts commit 20ecf9b.

* Revert "Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)" (openmrs#23)"

This reverts commit f2f81b0.

* Revert "Revert "OCLOMRS-21: Integrate Linting on CI and Prettier for better code" (openmrs#22)"

This reverts commit 5fcea0d.

* Revert "Revert "OCLOMRS-29: Restructure app to improve code maintainability" (openmrs#21)"

This reverts commit f6d6d28.

* Revert "Revert "OCLOMRS-17: Protect routes that require authentication (openmrs#12)" (openmrs#20)"

This reverts commit f6be69c.

OCLOMRS-35: display sources and enable searching (openmrs#26)

OCLOMRS-40: redesign sources page user interface (openmrs#27)

OCLOMRS-36: paginate search results (openmrs#28)
kirity-mahanty added a commit that referenced this pull request Sep 30, 2020
…ncepts in a Source (#614)

* Tarun, Kirity | OCLOMRS-868 | MOBN-1390 | View the total number of concepts in a Source (#27)

* Tarun | Kirity | MOBN-1390 | View the total number of concepts in a Source

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Unit tests

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Added active and retired concepts

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Refactored code

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Added unit tests

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Refactored code

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated title for concept summary block

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated component name

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated component name in test file

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated viewSourcePage snapshot test to include concept summary

Co-authored-by: Kirity Mahanty <kirity.mahanty@thoughtworks.com>

* Tarun, Bindu | OCLOMRS-868 | MOBN-1453 | Fix data discrepancy in Concept Summary Section for Active and Total Number of Concepts (#37)

* Tarun, Bindu | MOBN-1453 | Fix concept summary details in source details page

* Tarun,Bindu | MOBN-1453 | Corrected Typo in actiontype

* Tarun, Bindu | MOBN-1453 | Refactored code and added unit tests

* Tarun, Bindu | MOBN-1453 | Add test cases for get activeConcepts api and viewSourcePage container

* Tarun, Bindu | MOBN-1453 | Fix the broken UI for longtext for supported locale, owner_url

* Tarun, Bindu | MOBN-1453 | Remove multiline prop for supported locale field in both Dictionary Form and Source Form

* Tarun | MOBN-1453 | Handled feedback changes

* Tarun | MOBN-1453 | Refactored retrive concepts api call

* Tarun | MOBN-1453 | Handle feedback changes

Co-authored-by: tarunkumar-tw <tarunkumar.s@thoughtworks.com>

Co-authored-by: Kirity Mahanty <kirity.mahanty@thoughtworks.com>
Co-authored-by: Himabindu T <tbindu@thoughtworks.com>
kirity-mahanty added a commit that referenced this pull request Sep 30, 2020
…ilable in a Source (#615)

* Tarun, Kirity | OCLOMRS-868 | MOBN-1390 | View the total number of concepts in a Source (#27)

* Tarun | Kirity | MOBN-1390 | View the total number of concepts in a Source

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Unit tests

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Added active and retired concepts

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Refactored code

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Added unit tests

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Refactored code

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated title for concept summary block

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated component name

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated component name in test file

* Tarun, Kirity | MOBN-1390 | View the total number of concepts in a Source - Updated viewSourcePage snapshot test to include concept summary

Co-authored-by: Kirity Mahanty <kirity.mahanty@thoughtworks.com>

* Tarun, Bindu | OCLOMRS-868 | MOBN-1453 | Fix data discrepancy in Concept Summary Section for Active and Total Number of Concepts (#37)

* Tarun, Bindu | MOBN-1453 | Fix concept summary details in source details page

* Tarun,Bindu | MOBN-1453 | Corrected Typo in actiontype

* Tarun, Bindu | MOBN-1453 | Refactored code and added unit tests

* Tarun, Bindu | MOBN-1453 | Add test cases for get activeConcepts api and viewSourcePage container

* Tarun, Bindu | MOBN-1453 | Fix the broken UI for longtext for supported locale, owner_url

* Tarun, Bindu | MOBN-1453 | Remove multiline prop for supported locale field in both Dictionary Form and Source Form

* Tarun | MOBN-1453 | Handled feedback changes

* Tarun | MOBN-1453 | Refactored retrive concepts api call

* Tarun | MOBN-1453 | Handle feedback changes

Co-authored-by: tarunkumar-tw <tarunkumar.s@thoughtworks.com>

* Vinisha, Tarun | OCLOMRS-867 | MOBN-1459 | View the list of concepts that are available in a Source

Co-authored-by: tarunkumar-tw <58736833+tarunkumar-tw@users.noreply.github.com>
Co-authored-by: Kirity Mahanty <kirity.mahanty@thoughtworks.com>
Co-authored-by: Himabindu T <tbindu@thoughtworks.com>
Co-authored-by: tarunkumar-tw <tarunkumar.s@thoughtworks.com>
Co-authored-by: Kirity Mahanty <58568821+kirity-mahanty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants