-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCLOMRS-1065: Upgrade the MUI to version 5 in dictionary manager #760
Conversation
Hi @ibacher, I have tried to upgrade to MUI 5 but the default theme provider is not supported in MUI5 so I got an error at. So, I added a ThemeProvider in root file but still I got the same error. So I tried using Theme from "@mui/material" which do not give the same UI as expected. Please have a look at the issue I am getting. I still need to do more Q/A in this PR but I am stuck at theme. |
Hi @ibacher, @hadijahkyampeire helped me figure out the issue with the navbar, it was not working because mui5 has added px as the default unit. But still, there are some UI improvements needed so just changing this PR to draft. |
"@emotion/react": "^11.4.1", | ||
"@emotion/styled": "^11.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need "@emotion/react" and "@emtion/styled"? I know that MUI is using them under the hood, but we don't seem to be actually using them anywhere and it's better to keep the dep list as minimal as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @ibacher, for the review. I had not used emotion at the beginning but it ended up with some error Unhandled Rejection error in Reducer. And was fixed by adding emotion so had to add this dep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the minor comment I've left, I'm happy for this to be merged in. Nice work @suruchee!
Where we have to use test ids, can we try using |
JIRA TICKET NAME:
Upgrade the mui to version 5 in dictionary manager
Summary:
Upgrade to MaterialUI 5