OWA-41: Add manage settings page #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @wanjikum for reviewing. 👍 |
dkayiwa
reviewed
Sep 7, 2017
bower.json
Outdated
| "Web", | ||
| "App" | ||
| ], | ||
| "homepage": "https://github.com/andela-jomadoye/openmrs-owa-addonmanager", |
dkayiwa
reviewed
Sep 7, 2017
| event.preventDefault(); | ||
| this.setState({ | ||
| AppBaseURLValue: '', | ||
| AppFolderPathValue: 'appdata\\owa', |
There was a problem hiding this comment.
@dkayiwa It is only 1 backslash that appears, the second backslash is used to escape it. The final output is appdata\owa
dkayiwa
reviewed
Sep 7, 2017
|
|
||
| componentWillMount() { | ||
| this.setState({ | ||
| AppFolderPathValue: 'appdata\\owa', |
There was a problem hiding this comment.
The double backslash is used to escape the backslash slash.
|
Thanks @dkayiwa all issues have been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA TICKET NAME:
OWA-41: Create Add-on Management setting UI as a migrate from the Legacy UI
SUMMARY:
This PR creates a page for the manages OWA settings.