Skip to content

Commit

Permalink
Merge pull request #20 from ridmal/issue_18
Browse files Browse the repository at this point in the history
Configure EsLint and Hound
  • Loading branch information
JudeNiroshan committed Apr 7, 2018
2 parents 8fb3411 + 790f1b1 commit adf6fa3
Show file tree
Hide file tree
Showing 39 changed files with 1,652 additions and 1,500 deletions.
9 changes: 9 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
app/js/__tests__/**
app/js/__mocks__/**
node_modules/**
dist/**
libs/**
app/manifest.webapp
*.css
*.png
*.html
73 changes: 73 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
{
"extends": [
"eslint:recommended",
"plugin:import/errors",
"plugin:import/warnings"
],
"plugins": ["react"],
"parserOptions": {
"ecmaVersion": 6,
"sourceType": "module",
"ecmaFeatures": {
"jsx": true
}
},
"globals": {
"toastr": true
},
"env": {
"es6": true,
"browser": true,
"node": true,
"jquery": true,
"mocha": true
},
"rules": {
"indent": [1, 2, { "SwitchCase": 1 }],
"quotes": 0,
"no-console": 1,
"no-debugger": 1,
"no-var": 1,
"import/no-unresolved": 0,
"import/ignore": 0,
"semi": [1, "always"],
"no-trailing-spaces": 0,
"eol-last": 0,
"no-unused-vars": 0,
"no-underscore-dangle": 0,
"no-alert": 0,
"no-lone-blocks": 0,
"jsx-quotes": 1,
"react/display-name": [ 1, {"ignoreTranspilerName": false }],
"react/forbid-prop-types": [1, {"forbid": ["any"]}],
"react/jsx-boolean-value": [1,"always"],
"react/jsx-closing-bracket-location": 0,
"react/jsx-curly-spacing": 1,
"react/jsx-indent-props": 0,
"react/jsx-key": 1,
"react/jsx-max-props-per-line": 0,
"react/jsx-no-bind": 0,
"react/jsx-no-duplicate-props": 1,
"react/jsx-no-literals": 0,
"react/jsx-no-undef": 1,
"react/jsx-pascal-case": 1,
"react/jsx-sort-prop-types": 0,
"react/jsx-sort-props": 0,
"react/jsx-uses-react": 1,
"react/jsx-uses-vars": 1,
"react/no-danger": 1,
"react/no-did-mount-set-state": 1,
"react/no-did-update-set-state": 1,
"react/no-direct-mutation-state": 1,
"react/no-multi-comp": 1,
"react/no-set-state": 0,
"react/no-unknown-property": 1,
"react/prefer-es6-class": 1,
"react/prop-types": 1,
"react/react-in-jsx-scope": 1,
"import/extensions": [1,"never", { "css": "always" }],
"react/self-closing-comp": 1,
"react/sort-comp": 1,
"react/jsx-wrap-multilines": 1
}
}
4 changes: 4 additions & 0 deletions .hound.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
eslint:
enabled: true
config_file: .eslintrc
ignore_file: .eslintignore
1 change: 1 addition & 0 deletions app/js/__tests__/reports/common/BasicXYChart.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React from 'react';
import renderer from 'react-test-renderer';
import Line from 'react-chartjs';
import Chart from 'chart.js';
import { fakeRequestLibrary } from '../../../__mocks__/fakeRequestLibrary';
import { FAKE_RESPONSE } from '../../../__mocks__/fakeResponse';
import BasicXYChart from '../../../components/reports/common/BasicXYChart';
Expand Down
36 changes: 18 additions & 18 deletions app/js/components/App.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,34 +10,34 @@
* Copyright (C) OpenMRS, LLC. All Rights Reserved.
*/
import React from 'react';
import {Header} from './common/Header';
import { Header } from './common/Header';
import BreadCrumbComponent from './breadCrumb/breadCrumbComponent';
import MainLayout from './common/MainLayout';
import "./app.css";

export default class App extends React.Component {

constructor(props) {
super(props);
this.state = {
display: 'block'
};
}
super(props);
this.state = {
display: 'block'
};
}

render() {
const display = this.state;
return (
<div>
<div id="tabbed-cohort" className="header-component">
<Header/>
<BreadCrumbComponent/>
</div>
<div id="body-wrapper">
<div id="displayReports" className="col-md-12 section">
<MainLayout />
</div>
</div>
</div>
);
<div>
<div id="tabbed-cohort" className="header-component">
<Header />
<BreadCrumbComponent />
</div>
<div id="body-wrapper">
<div id="displayReports" className="col-md-12 section">
<MainLayout />
</div>
</div>
</div>
);
}
}
30 changes: 15 additions & 15 deletions app/js/components/breadCrumb/breadCrumbComponent.jsx
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
import React, {Component} from 'react';
import {Link} from 'react-router';
import React, { Component } from 'react';
import { Link } from 'react-router';

import './breadCrumb.css';

class BreadCrumbComponent extends Component{
componentDidMount(){}
class BreadCrumbComponent extends Component {
componentDidMount() { }

render(){
return (
<div className="breadcrumb">
<a href="/openmrs" className="breadcrumb-item">
<span className="glyphicon glyphicon-home breadcrumb-item" aria-hidden="true"></span>
</a>
<span className="glyphicon glyphicon-chevron-right breadcrumb-item separator" aria-hidden="true"></span>
<span className="title breadcrumb-item">Built-in Reports</span>
</div>
);
}
render() {
return (
<div className="breadcrumb">
<a href="/openmrs" className="breadcrumb-item">
<span className="glyphicon glyphicon-home breadcrumb-item" aria-hidden="true" />
</a>
<span className="glyphicon glyphicon-chevron-right breadcrumb-item separator" aria-hidden="true" />
<span className="title breadcrumb-item">Built-in Reports</span>
</div>
);
}
}

export default BreadCrumbComponent;
Loading

0 comments on commit adf6fa3

Please sign in to comment.