Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using bitset2. #549

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Switch to using bitset2. #549

wants to merge 2 commits into from

Conversation

Y-Less
Copy link
Collaborator

@Y-Less Y-Less commented Dec 27, 2022

This doesn't make a difference at this stage, but is a precursor to some other changes intended to generally improve memory consumption. Most importantly bitset2 has one very important new function - find_first. It isn't quite as efficient as my method was (see Hacker's Delight, ISBN 9780201914658), but I've forked the original project so we can add internal improvements as we need.

This doesn't make a difference at this stage, but is a precursor to some other changes intended to generally improve memory consumption.  Most importantly bitset2 has one very important new function - `find_first`.  It isn't quite as efficient as my method was (see Hacker's Delight, ISBN  9780201914658).
@Y-Less Y-Less mentioned this pull request Dec 27, 2022
@Y-Less
Copy link
Collaborator Author

Y-Less commented Dec 27, 2022

OK, Linux apparently has exceptions disabled, while Windows doesn't.

@Y-Less
Copy link
Collaborator Author

Y-Less commented Dec 27, 2022

Which is weird, because throw is used in plenty of other places.

This compiled on Windows because the code wasn't used, but failed on Linux because it was checked anyway.
@Y-Less
Copy link
Collaborator Author

Y-Less commented Dec 27, 2022

Hopefully fixed that, but as I wrote this as a precursor to some more changes, that aren't really needed since #550 does a good enough job for now, we can leave this for a bit.

@ksenonadv ksenonadv changed the title Switch to using bitset2. [DRAFT] Switch to using bitset2. Dec 29, 2022
@AmyrAhmady AmyrAhmady changed the title [DRAFT] Switch to using bitset2. Switch to using bitset2. Jun 8, 2023
@AmyrAhmady AmyrAhmady marked this pull request as draft June 20, 2023 02:44
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Y_Less seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants