Fix markdown titles not showing hashes literally #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brynhughes You appear to be the only active contributor on this repository at the moment. This is a really small fix, would you mind merging this? |
dylan-chong
commented
Jun 27, 2018
| @@ -8,7 +8,7 @@ For many different reasons, a great deal of music written in the late eighteenth | |||
|
|
|||
| Music in the classical tradition was quite often less subservient to the two- and four-bar units. While this topic has been the subject of a great deal of musical theoretical exploration, here we will concentrate on a simple and common type of *sub-phrase* and *phrase expansion*. | |||
|
|
|||
| ##Sub-phrase Expansion## | |||
There was a problem hiding this comment.
I removed the trailing hashes to be consistent with every other heading
|
@dylan-chong @kshaffer @brynhughes |
|
Would be great to get this merged
… On 12/10/2018, at 4:22 AM, RJ Salvador ***@***.***> wrote:
@dylan-chong @kshaffer @brynhughes
Any chance of getting some approval to merge this in?
It's nitpicky, but pretty obvious on the webpage.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@kshaffer @brynhughes hello? it's been a little while... 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.