modules/py_tf: Fix non-square image support. #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on OpenMV Forums. There might be relevant details there: https://forums.openmv.io/t/edge-impulse-result-wrong-on-openmv-h7-plus/8968/7 |
kwagyeman
force-pushed
the
kwabena/py_tf_fix_segment
branch
2 times, most recently
from
a60609a
to
2b287d4
Compare
iabdalkader
requested changes
Dec 3, 2023
kwagyeman
force-pushed
the
kwabena/py_tf_fix_segment
branch
from
2b287d4
to
7fe757f
Compare
kwagyeman
force-pushed
the
kwabena/py_tf_fix_segment
branch
from
7fe757f
to
70b2db2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-square image support has not been working for a long time. This forum post pointed out the issue: https://forums.openmv.io/t/edge-impulse-result-wrong-on-openmv-h7-plus/8968/3.
Code is now updated to use the new draw image scaling and centering logic. This applies for classification and segmentation/detect.
Then segmentation has been updated to locate the final result in the right location given all the scaling and cropping going on when your image aspect ratio does not match the CNN aspect ratio.