Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

443 production datepicker styles #453

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Conversation

gsehrlich
Copy link
Collaborator

@gsehrlich gsehrlich commented Apr 5, 2022

Checklist

  • Add description
  • Reference the open issue that the pull request addresses
  • Pass code quality checks
    • spin up docker docker-compose up -d --build
    • enter api container docker-compose exec api /bin/bash
    • run api tests make validate
    • exit container ctrl/command+D or exit
    • enter web container docker-compose exec web /bin/sh
    • run front-end tests npm run test or npx jest
    • lint npm run lint-fix
    • exit container as above
  • Request code review
    • Please allow 36 hours from opening a pull request before merging a pull request- even if it has already received an approving review.
  • Address comments on code and resolve requested changes
  • Merge own code

Description

Issue: #443

Brief description of solution

  1. Fix the opacity by switching from percentages to decimals. The development version didn't have this issue for some reason. https://stackoverflow.com/questions/58853844/the-opacity-value-was-changed-to-1-after-building-the-reacjs-project
  2. The ordering issue was caused by semantic-ui-react-datepickers styles that were duplicated in a <style> tag in the production build for some reason, overriding the CSS. Put a div selector before the class in the CSS to give it higher specificity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants