Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Transit -> Buses -> Bus (Inside), Bus (Outside) #12

Closed
jayshao opened this issue Oct 14, 2020 · 5 comments
Closed

Add: Transit -> Buses -> Bus (Inside), Bus (Outside) #12

jayshao opened this issue Oct 14, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jayshao
Copy link
Contributor

jayshao commented Oct 14, 2020

Outmoove suggests adding and replacing the Grandchild Buses with two new grandchildren categories, which targets difference audience within the bus, or at the street level.

@jayshao jayshao added this to the 1.4 milestone Oct 14, 2020
@mowasfi7
Copy link
Contributor

+1

@jayshao jayshao modified the milestones: 1.4, 1.3 Oct 15, 2020
@christiancollins11
Copy link
Contributor

+1

@jayshao jayshao modified the milestones: 1.4, 1.1 Feb 18, 2021
@jayshao
Copy link
Contributor Author

jayshao commented Feb 18, 2021

Would we want to genericize this to a pattern for... all vehicles? Buses, Taxis, Planes, Subway?

From a compatibility perspective - I assume we're talking about more leaf-nodes vs. creating a "great-grand-child" level of hierarchy?

I think that would look like: creating a parallel entry and clarifying that "Bus" is... inside a bus? The Children descriptions imply that "Displays located on the inside of city or intercity buses." - though there are then children including "Terminal" which break that :) But - in the interest of managing complexity and reserving future leaf nodes - perhaps "Bus" for example could be redefined to "Bus (Inside)" and a new "Bus (Outside)

@jayshao jayshao added enhancement New feature or request help wanted Extra attention is needed labels Feb 18, 2021
@bruno8g
Copy link

bruno8g commented Feb 22, 2021

I agree that this should be applicable to most Child in the transit category - outside and inside. My preference would be to use Grandchild.

@jayshao jayshao modified the milestone: 1.1 Feb 23, 2021
@jayshao jayshao self-assigned this Feb 23, 2021
jayshao added a commit that referenced this issue Mar 5, 2021
#12 initial commit of just bus inside/outside clarification
@jayshao
Copy link
Contributor Author

jayshao commented Mar 5, 2021

added a pass for bus - if that looks good to others, we could try to genericise further

jayshao added a commit that referenced this issue Mar 5, 2021
#12 initial definitions for most grandchildren
@jayshao jayshao removed help wanted Extra attention is needed ready for review labels Mar 11, 2021
@jayshao jayshao closed this as completed Mar 11, 2021
@jayshao jayshao changed the title Addition of Grandchildren Inside Bus & Outside Bus to transit.buses Add: Transit -> Buses -> Bus (Inside), Bus (Outside) Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants