Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Health and Beauty -> Salons -> Unisex / Men's / Women's Men's #22

Closed
ndbabb opened this issue Oct 18, 2020 · 6 comments
Closed

Add: Health and Beauty -> Salons -> Unisex / Men's / Women's Men's #22

ndbabb opened this issue Oct 18, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ndbabb
Copy link
Contributor

ndbabb commented Oct 18, 2020

No description provided.

@mowasfi7
Copy link
Contributor

+1

@jayshao jayshao added the enhancement New feature or request label Feb 18, 2021
@jayshao jayshao added this to the 1.1 milestone Feb 18, 2021
@christiancollins11
Copy link
Contributor

+1, prefer this approach to #48

@swe-vas
Copy link

swe-vas commented Feb 20, 2021

  • Makes sense to add barbershop as it's a more specific representation.
  • Downvote the request to add "Women's Salons" - most salons are unisex these days, and if there are some that cater more to womxn can that not be identified with the help of audience demographics?

@bruno8g
Copy link

bruno8g commented Feb 22, 2021

+1

@jayshao jayshao modified the milestone: 1.1 Feb 23, 2021
@jayshao
Copy link
Contributor

jayshao commented Feb 23, 2021

I think in summary - the majority consensus seems to be to add grandchildren to Salons for "Barbershop".

It seems like in general... there's also support for adding Women's salons to maintain parity - though perhaps if we branch into that category, it's worth making it 3 children:

  • Barbershops
  • Women's salons
  • Unisex salons

?

@jayshao jayshao self-assigned this Feb 23, 2021
@jayshao
Copy link
Contributor

jayshao commented Mar 5, 2021

Added a simple list with unisex, men, women - was having trouble with if "barbershop" would necessitate other categories like "more full service" salon - but not sure this is the right distinction either - or that that isn't a desireable split

jayshao added a commit that referenced this issue Mar 5, 2021
#22 add salons catering to specific genders
@jayshao jayshao changed the title Add Men's Salons and Women's Salons as grandchildren under Salon Add: Health and Beauty -> Salons -> Unisex / Men's / Women's Men's Mar 5, 2021
@jayshao jayshao closed this as completed Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants