-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for OpenMM 7.6 #50
Updates for OpenMM 7.6 #50
Conversation
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 1202 1204 +2
=========================================
+ Hits 1202 1204 +2
Continue to review full report at Codecov.
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Fri 03 Sep 01:00 GMT (Thu 02 Sep 21:00 my local). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple left over old code and missing reasons for skips. I am not too happy about the code duplication on the test files (around the imports), but this is easier to understand than indirect imports, so no favor one way or another (As long as it exists in just 2 files)
Made changes, though not quite the ones you suggested. I intentionally left the commented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Most significantly, this fixes a test error on the URL that @sroet suggested I add a test for (thanks @sroet!) by removing the
simtk
from the URL. I also went ahead and made it so we preferred new 7.6-style imports everywhere else.