Skip to content

Conversation

dwhswenson
Copy link
Member

This will add an interactive setup wizard to the OPS CLI. The wizard will guide users through the process of setting up simulation objects to use in a simulation, and will save the created objects to a SimStore database (hopefully with a little fun along the way). This PR will have support for a wizard to do flexible-length TPS simulation using an OpenMM engine and MDTraj CVs (tested by stepping through the setup for alanine dipeptide).

@dwhswenson dwhswenson changed the title [WIP] Simulation Setup Wizard Simulation Setup Wizard Jun 18, 2021
@dwhswenson
Copy link
Member Author

It looks like this needs to wait on the release of OPS 1.5

@dwhswenson
Copy link
Member Author

close/open to trigger CI

@dwhswenson dwhswenson closed this Jul 6, 2021
@dwhswenson dwhswenson reopened this Jul 6, 2021
@dwhswenson
Copy link
Member Author

This is ready for review and comment. I will leave it open for at least 72 hours, merging no earlier than Tue 27 Jul 15:00 GMT (11:00 my local).

This is a huge PR, and only intended to be a first draft of the OPS Wizard. For now, it gives some basic options for 2-state TPS. The API for this is very much in flux, and will probably be largely rewritten after I finish #43. I started out by writing the wizard before the file parsing, but in the end, it will make much more sense for the wizard to re-use a subset of the things in the file parsing.

@dwhswenson dwhswenson mentioned this pull request Jul 24, 2021
6 tasks
Copy link
Member

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar enough to fully grasp all the intricacies of the implementation, but I reviewed it looking for sub-optimal code/behviour. Feel free to ignore

@dwhswenson
Copy link
Member Author

Thanks for looking this (huge) PR over, @sroet! This and #43 represent a couple of really big additions, and since they add whole new subsystems, I sort of needed to add it all in one huge PR (I couldn't tell if any of it worked until I had written all of it.)

Merging this one in now.

@dwhswenson dwhswenson merged commit 012e2f5 into openpathsampling:main Jul 27, 2021
@dwhswenson dwhswenson deleted the wizard branch July 27, 2021 17:33
@dwhswenson dwhswenson mentioned this pull request Sep 2, 2021
@dwhswenson dwhswenson mentioned this pull request Oct 7, 2021
@dwhswenson dwhswenson mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants