Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FutureWarning for default filesetter external engines #1102

Merged
merged 2 commits into from Jan 28, 2022

Conversation

sroet
Copy link
Member

@sroet sroet commented Jan 27, 2022

this adds a FutureWarning to let users know that in OPS 2.0 the default FileSetter will become random string

This was part of the discussion on #1101

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1102 (d342f02) into master (dd2cad5) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1102   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         142      142           
  Lines       15611    15612    +1     
=======================================
+ Hits        12763    12764    +1     
  Misses       2848     2848           
Impacted Files Coverage Δ
openpathsampling/engines/external_engine.py 84.39% <80.00%> (ø)
openpathsampling/deprecations.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2cad5...d342f02. Read the comment docs.

Copy link
Member

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the one spelling change I'll enforce.

openpathsampling/deprecations.py Outdated Show resolved Hide resolved
@dwhswenson dwhswenson merged commit 9131891 into openpathsampling:master Jan 28, 2022
@sroet sroet deleted the issue_1101_1x_default branch January 31, 2022 09:16
@sroet sroet mentioned this pull request Feb 3, 2022
@dwhswenson dwhswenson mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants