Update standard filename setter for external engines in OPS 2.0 #1103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple things:
filename_setter
forExternalEngines
are nowRandomStringFilenames
instead ofFilenameSetter
FilenameSetter
is now a subclass ofRandomStringFilenames
(instead of the other way around) (this was needed to still be able to use Filename setter after changing the default options)FilenameSetter now returns a string that is padded up to
self.length` with zeroesGromacsEngine.set_filenames
only resets thefilename_setter
if thefilename_setter
has areset
attributenose
from all touched testspart of the discussion on #1101