Fix bug in SimStore when appending to non-existent files #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroet
requested changes
Nov 7, 2020
| @@ -5,7 +5,7 @@ | |||
| import logging | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| class SimpleNamespace(collections.MutableMapping): | |||
| class SimpleNamespace(collections.abc.MutableMapping): | |||
There was a problem hiding this comment.
Any reason why this file does not do a similar thing as memory_backend.py (or the other way around)?
(Define abc and use that)
There was a problem hiding this comment.
No particular reason. I don't really have a consistent style when it comes to imports. I went ahead and switched this to just use abc. Really, I should have been using the separate abc package for Py27, not collections.MutableMapping. I think the previous existence of that package is why I prefer from collections import abc (plus it is much shorter). On the other hand, I usually just do import os when using things in os.path, so there's not a general rule to apply.
Co-authored-by: Sander Roet <sanderroet@hotmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much what the title says. Before, there was an error if you opened a new file as append, because it tried to read the non-existent schema from the file.
Also cleans up some deprecations from importing ABCs from
collections, notcollections.abc(SimStore is Python 3+.)