Skip to content


Subversion checkout URL

You can clone with
Download ZIP


Fix oauth first-time bug #22

creationix opened this Issue · 5 comments

2 participants


The first time a github oauth token is granted the postMessage never makes it to the parent page.

@creationix creationix was assigned

Seeing this behavior for all attempted logins = can't get past the login screen. Closed tab, re-opened, CMD+R, login, see the popup, no error, no login.

Not working in Chrome Canary either.


Changed the oauth flow to not use a popup window and instead use full-page redirects.

To test any page other than the / route you need to specify the HOME_URL environment variable.

For example, to test oauth with /testfinder.html you need to start the server like:

HOME_URL=/testfinder.html node server.js

and then point the browser to http://localhost:8080/testfinder.html

@creationix creationix closed this

The demo page still pops a page, but now it loads the login page in the popup. When I click login inside the popup it seems to reload same page = can't log in.


Ah yea, just figured that was done, my bad. Turning QA knob off for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.