Fix oauth first-time bug

[creationix]

The first time a github oauth token is granted the postMessage never makes it to the parent page.

[ghost]

Seeing this behavior for all attempted logins = can't get past the login screen. Closed tab, re-opened, CMD+R, login, see the popup, no error, no login.

Not working in Chrome Canary either.

[creationix]

Changed the oauth flow to not use a popup window and instead use full-page redirects.

To test any page other than the / route you need to specify the HOME_URL environment variable.

For example, to test oauth with /testfinder.html you need to start the server like:

HOME_URL=/testfinder.html node server.js

and then point the browser to http://localhost:8080/testfinder.html

[ghost]

The demo page still pops a page, but now it loads the login page in the popup. When I click login inside the popup it seems to reload same page = can't log in.

[creationix]

I guess I shouldn't have closed this till it was integrated with the real
front-end and pushed to the live server.

On Thu, Mar 28, 2013 at 6:20 PM, Open Peer notifications@github.com wrote:

The demo page still pops a page, but now it loads the login page in the
popup. When I click login inside the popup it seems to reload same page =
can't log in.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/22#issuecomment-15621257
.

[ghost]

Ah yea, just figured that was done, my bad. Turning QA knob off for now.