Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCRtpCodecParameters clock rate nullable? #500

Closed
robin-raymond opened this issue Apr 24, 2016 · 2 comments
Closed

RTCRtpCodecParameters clock rate nullable? #500

robin-raymond opened this issue Apr 24, 2016 · 2 comments
Labels
1.1 PR exists

Comments

@robin-raymond
Copy link
Contributor

clockRate of type unsigned long
Codec clock rate expressed in Hertz, null if unset.

It's not nullable. I think it should just say:

Codec clock rate expressed in Hertz; clock rate is defaulted if unset.

... or something like that....
@aboba aboba added the 1.1 label Apr 25, 2016
@aboba
Copy link
Contributor

aboba commented Apr 25, 2016

Related to Issue #503

Can we say that it would default to the value included in RTCRtpCodecCapability.clockRate ?

aboba added a commit that referenced this issue Apr 25, 2016
@aboba
RTCRtpCodecParameters clock rate nullable
182eeaa 
Fix for Issue #500
@aboba aboba mentioned this issue Apr 25, 2016
Merged
@robin-raymond
Copy link
Contributor Author

Better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.1 PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aboba @robin-raymond