You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Stop accepting pull requests that introduce bloat-features like localStorage and integration with remote key repositories! Those have no place in the core project. A PGP library should do one thing and do it well - handle crypto.
If you think those extra features are useful to someone then consider implementing a plugin system and making them available as optional plugins. Then the larger community can add whatever else they need, for example IndexedDB store, integration with Keybase.io, etc., etc.
Alternatively, you could issue OpenPGP Lite (or Lean) that does only crypto and none of the over-engineered bloat.
I hope you don't take my sharp tone as offensive. OpenPGP has become very popular and being the only JS library that does PGP, it has become very important for the community.
The text was updated successfully, but these errors were encountered:
@tanx has been very vocal about wanting to move to a plugin-based system for these useful but not 'core' extra features. We are all in agreement on this.
I think there actually isn't much involved in moving stuff into modules. We already use ES6 modules and basically just append a module e.g hkp to the default openpgp module before exporting it. I suggested a proposal to move optional to their own github repos under this GH organisation e.g openpgp-hkp and load that as a seperate npm module if required in a project:
Stop accepting pull requests that introduce bloat-features like localStorage and integration with remote key repositories! Those have no place in the core project. A PGP library should do one thing and do it well - handle crypto.
If you think those extra features are useful to someone then consider implementing a plugin system and making them available as optional plugins. Then the larger community can add whatever else they need, for example IndexedDB store, integration with Keybase.io, etc., etc.
Alternatively, you could issue OpenPGP Lite (or Lean) that does only crypto and none of the over-engineered bloat.
I hope you don't take my sharp tone as offensive. OpenPGP has become very popular and being the only JS library that does PGP, it has become very important for the community.
The text was updated successfully, but these errors were encountered: