Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] Remove boat from OpenPGP #420

Closed
sgnix opened this issue Mar 19, 2016 · 3 comments
Closed

[request] Remove boat from OpenPGP #420

sgnix opened this issue Mar 19, 2016 · 3 comments

Comments

@sgnix
Copy link

sgnix commented Mar 19, 2016

Stop accepting pull requests that introduce bloat-features like localStorage and integration with remote key repositories! Those have no place in the core project. A PGP library should do one thing and do it well - handle crypto.

If you think those extra features are useful to someone then consider implementing a plugin system and making them available as optional plugins. Then the larger community can add whatever else they need, for example IndexedDB store, integration with Keybase.io, etc., etc.

Alternatively, you could issue OpenPGP Lite (or Lean) that does only crypto and none of the over-engineered bloat.

I hope you don't take my sharp tone as offensive. OpenPGP has become very popular and being the only JS library that does PGP, it has become very important for the community.

@bartbutler
Copy link
Member

@tanx has been very vocal about wanting to move to a plugin-based system for these useful but not 'core' extra features. We are all in agreement on this.

@sgnix
Copy link
Author

sgnix commented Mar 19, 2016

Great! Looking forward to using a modular OpenPGP. Let me know if you need help.

@sgnix sgnix closed this as completed Mar 19, 2016
@tanx
Copy link
Member

tanx commented Mar 20, 2016

I think there actually isn't much involved in moving stuff into modules. We already use ES6 modules and basically just append a module e.g hkp to the default openpgp module before exporting it. I suggested a proposal to move optional to their own github repos under this GH organisation e.g openpgp-hkp and load that as a seperate npm module if required in a project:

#321 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants