key: Do not require users for parsing

[wiktor-k]

This is a draft PR to get the CI results until I figure out why my npm test complains about missing asmcrypto modules :)

[twiss]

(Sorry for the force push - didn't realize this would happen. Please git reset --hard ec650e6 && git cherry-pick e2afcf1 or whatever your latest local commit was - it should apply cleanly.)

The CI passed, but I guess this means there were no keys without User IDs in the test suite. Perhaps it would be good to add one, and test that we can parse it but not encrypt with it?

Re. npm, you might have to npm install --only=dev to install the devDependencies, or something? 🤷‍♂️

[wiktor-k]

(Sorry for the force push - didn't realize this would happen. Please git reset --hard ec650e6 && git cherry-pick e2afcf1 or whatever your latest local commit was - it should apply cleanly.)

I was just looking at the commit list wondering what happened... thanks for the instructions! 👍

The CI passed, but I guess this means there were no keys without User IDs in the test suite. Perhaps it would be good to add one, and test that we can parse it but not encrypt with it?

Yep, definitely. I'll be back with some more comprehensive test. Still I was surprised that not one test out of over 700 failed... 😱

Re. npm, you might have to npm install --only=dev to install the devDependencies, or something?

Install still fails with:

❯ npm install --only=dev
> openpgp@4.10.7 prepare /home/wiktor/src/open-source/openpgpjs
> npm run build
> openpgp@4.10.7 build /home/wiktor/src/open-source/openpgpjs
> rollup --config
src/index.js → dist/openpgp.js, dist/openpgp.min.js, dist/openpgp.mjs, dist/openpgp.min.mjs...
(!) Missing global variable names
Use output.globals to specify browser global variable names corresponding to external modules
asmcrypto.js/dist_es8/aes/ecb (guessing 'ecb')
asmcrypto.js/dist_es8/hash/sha1/sha1 (guessing 'sha1$1')
asmcrypto.js/dist_es8/hash/sha256/sha256 (guessing 'sha256$1')
asmcrypto.js/dist_es8/aes/cfb (guessing 'cfb$1')
asmcrypto.js/dist_es8/aes/gcm (guessing 'gcm')
asmcrypto.js/dist_es8/aes/ctr (guessing 'ctr')
asmcrypto.js/dist_es8/aes/cbc (guessing 'cbc')
asmcrypto.js/dist_es8/aes/ecb (guessing 'ecb')
asmcrypto.js/dist_es8/hash/sha1/sha1 (guessing 'sha1$1')
asmcrypto.js/dist_es8/hash/sha256/sha256 (guessing 'sha256$1')
asmcrypto.js/dist_es8/aes/cfb (guessing 'cfb$1')
asmcrypto.js/dist_es8/aes/gcm (guessing 'gcm')
asmcrypto.js/dist_es8/aes/ctr (guessing 'ctr')
asmcrypto.js/dist_es8/aes/cbc (guessing 'cbc')
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
asmcrypto.js/dist_es8/aes/cfb (imported by src/crypto/cfb.js)
asmcrypto.js/dist_es8/aes/gcm (imported by src/crypto/gcm.js)
asmcrypto.js/dist_es8/aes/ctr (imported by src/crypto/eax.js)
...

but don't worry. I can create a test even without that and push it here and see it fail+pass. (it's weird that I ran the instructions even in docker run --rm -it -v ${PWD}:/code --entrypoint /bin/bash node and it still had some issues... oh, well... software 🤷‍♂️ )

Have a nice day! 👋

[wiktor-k]

Okay, phew. For such a tiny change I think this is now ready for review. Take a look at it @twiss and see if you can spot some places that are in need of improvement :)

[twiss]

👍 Thanks! ^.^