Rename config.ignoreMdcError, drop config.integrityProtect and allow V4 keys to be AEAD-encrypted
#1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, enforce integrity protection of new messages
twiss
reviewed
Mar 3, 2021
src/key/factory.js
Outdated
| } | ||
| // integrity protection always enabled | ||
| signaturePacket.features = [0]; | ||
| signaturePacket.features[0] |= enums.features.modificationDetection; | ||
| if (config.aeadProtect) { | ||
| signaturePacket.features || (signaturePacket.features = [0]); |
There was a problem hiding this comment.
This is very nitpicky but you can remove this line now (also the one in the next if)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
config.ignoreMdcErrortoconfig.allowUnauthenticatedMessagesconfig.integrityProtect: it is no longer possible to create messages without integrity protectionconfig.aeadProtectis now used when selecting the encryption mechanism of keys (previously, only v5 keys were encrypted using AEAD)