Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify algorithm preference selection and uniform config names #1262

Merged
merged 12 commits into from
Mar 10, 2021
Merged

Simplify algorithm preference selection and uniform config names #1262

merged 12 commits into from
Mar 10, 2021

Conversation

larabr
Copy link
Collaborator

@larabr larabr commented Mar 4, 2021 •
edited

Changes:

  • rename config.compression into config.preferredCompressionAlgorithm
  • rename config.encryptionCipher into config.preferredCipherAlgorithm
  • rename config.preferHashAlgorithm into config.preferredHashAlgorithm
  • rename config.aeadMode into config.preferredAEADAlgorithm
  • when encrypting to public keys, the compression/aead/cipher algorithm is selected by:
    • taking the preferred algorithm specified in config, if it is supported by all recipients
    • otherwise, taking the "MUST implement" algorithm specified by the OpenPGP spec
  • when encrypting to passphrases only (no public keys), the preferred algorithms from config are always used
  • EdDSA signing with hash weaker than sha256 is no longer allowed (https://tools.ietf.org/id/draft-ietf-openpgp-rfc4880bis-10.html#section-15-7.2)

twiss
twiss reviewed Mar 4, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/key/factory.js Outdated Show resolved Hide resolved
src/key/factory.js Outdated Show resolved Hide resolved
src/key/helper.js Outdated Show resolved Hide resolved
twiss
twiss reviewed Mar 5, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/openpgp.js Outdated Show resolved Hide resolved
src/message.js Outdated Show resolved Hide resolved
@larabr larabr marked this pull request as ready for review March 5, 2021 16:20
twiss
twiss reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@twiss twiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasingly nitpicky nitpicks

src/crypto/public_key/elliptic/eddsa.js Outdated Show resolved Hide resolved
src/message.js Outdated Show resolved Hide resolved
src/key/helper.js Outdated Show resolved Hide resolved
@larabr @twiss
Apply suggestions from code review
0db3524 
Co-authored-by: Daniel Huigens <d.huigens@protonmail.com>
twiss
twiss reviewed Mar 9, 2021
View reviewed changes
src/config/config.js Outdated Show resolved Hide resolved
@twiss twiss merged commit 43fb584 into openpgpjs:master Mar 10, 2021
@larabr larabr deleted the config-prefs branch June 10, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiss twiss twiss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@larabr @twiss