Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type definitions #1267

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Type definitions #1267

merged 3 commits into from
Mar 16, 2021

Conversation

sinderw
Copy link
Contributor

@sinderw sinderw commented Mar 15, 2021

  • Added key.write(), returning binary representation of a Key.
  • Added type definitions for key.write(), signature.write(), and message.write() to avoid dealing with packets.
  • Added type definitions for key certification and verification

Should we hide key.keyPacket, signature.packets and message.packets from the type definitions?

@twiss
Copy link
Member

twiss commented Mar 15, 2021

Thanks for the PR!

Should we hide key.keyPacket, signature.packets and message.packets from the type definitions?

Yeah, I think we could mark them as private 👍

@sinderw
Copy link
Contributor Author

sinderw commented Mar 15, 2021

Right, I marked them private 👍

@twiss twiss merged commit eba791e into openpgpjs:master Mar 16, 2021
@twiss
Copy link
Member

twiss commented Mar 16, 2021

👍 Thanks!

@sinderw sinderw deleted the type-definitions branch March 16, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sinderw @twiss