[v6] Use WebCrypto for AES-KW, drop AES_ECB dependency #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
commented
Feb 8, 2024
larabr
force-pushed
the
v6-aes-kw-webcrypto
branch
from
6541032
to
9e66f77
Compare
twiss
approved these changes
Feb 26, 2024
Fallback needed for AES192, due to missing Chromium support.
The module was barely used, and its presence confusing, since WebCrypto or asmcrypto are often directly used and usable instead. Also, use AES_CBC instead of AES_ECB for single-block encryption, so that we can drop support for the latter in the asmcrypto lib.
larabr
force-pushed
the
v6-aes-kw-webcrypto
branch
from
9e66f77
to
e0bae31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AES_CBC is now used instead of AES_ECB for single-block encryption. AES_CBC is implemented by WebCrypto, which can be used when encrypting (but not when decrypting, due to mandatory PKCS7 padding).
TODO: