fix worker instance misconfiguration #261
Conversation
|
Thanks for the PR. After you add a unit test and adjust the documentation it will be merged |
|
Any progress on this? Do we even need a unit test since this is in the tests anyway? thoughts? |
|
Added the test. Not sure why it fails on that |
| * @param {String} path relative path to the worker scripts | ||
| */ | ||
| function initWorker(path) { | ||
| asyncProxy = new AsyncProxy(path); | ||
| asyncProxy = new AsyncProxy(path,this.config); |
There was a problem hiding this comment.
Sorry to be nitpicking. Please use a space between args here to keep the code styles consistent.
|
Thanks for getting back to the PR. I've looked over the code and all in all it looks good. Just made some minor remarks. Nothing major.
Mmmmh. Not sure what the issue is here either. This is what travis tells us: Maybe debugging locally will help you to spot the underlaying issue? |
|
ok, I've just got the test tools working (the were issues on MacOsX) on Ubuntu, so will fix it soon. |
|
I manually merged this here da3dbf7 |
Hi
I've added passing config into the worker. Could you please review.
Thanks