report choleskys in tmb

[clarkliming]

close #263

minimum changes to the current code to unblock other functionalities.

[danielinteractive]

Thanks Liming, general approach is good! Can we please avoid the duplicate code, by factoring out the common part of get_chol and fit_mmrm into helper function?
Also, please consider keeping get_chol as internal helper function. I don't think we would want to call this function as a user?

[github-actions]

Unit Tests Summary

       1 files       40 suites   15s ⏱️
   362 tests    323 ✔️ 39 💤 0 ❌
1 769 runs  1 728 ✔️ 41 💤 0 ❌

Results for commit 9764c69.

♻️ This comment has been updated with latest results.

[clarkliming]

thank you @danielinteractive for the comment. this PR was not finalized yet yesterday due to limited time, the PR is created just to say that I am working on it and has some progress to enable github action checks. Now it should be fine and ready for review.

For avoiding duplicated code, I think the majority of the code can not be reduced. A lot of code is to check the consistency between the new data and old data. Only thing duplicated is the TMB::MakeADFun but this is super short.

[danielinteractive]

Thanks Liming!
Yeah no worries, I just reviewed already yesterday because you requested review and it was not draft PR :-)
Regarding the file location, how about moving this to tmb.R?

[clarkliming]

very interestingly that the trigger of review seems to be automatic (even if you do not include anyone as reviewer)

[danielinteractive]

Thanks Liming, looks nice! Only few minor last suggestions, afterwards good to merge