Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDFM option set to SAT instead of KR in PROC MIXED #275

Merged
merged 1 commit into from
May 26, 2023

Conversation

PhilBoileau
Copy link
Collaborator

Addresses #274: The PROC MIXED wrapper function used in the simulation study assessing the impact of missing data erroneously set the degrees of freedom calculation to Kenward-Rogers. It is now set to Satterthwaite, the mmrm() default.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PhilBoileau ! Do we also need to rerun simulations now for the SAS part?

@github-actions
Copy link
Contributor

Unit Tests Summary

       1 files       40 suites   16s ⏱️
   362 tests    323 ✔️ 39 💤 0
1 769 runs  1 728 ✔️ 41 💤 0

Results for commit 6b4fa4a.

@PhilBoileau
Copy link
Collaborator Author

Sorry for the delay, @danielinteractive, I'm at a conference. I think it would be worth re-running a small portion of the simulation study to assess if the results are any different. My guess is that they're negligible. I can't rerun them myself though because I no longer have access to SAS Studio. Perhaps @juliadedic1 would be able to do this?

@danielinteractive
Copy link
Collaborator

Thanks @PhilBoileau , cool, no worries, it is not urgent - I will chat with Julia

@PhilBoileau
Copy link
Collaborator Author

Sounds good, thanks!

@PhilBoileau PhilBoileau merged commit b9df64e into main May 26, 2023
@PhilBoileau PhilBoileau deleted the 274-consistent-df-calculations-in-simulations branch May 26, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants