-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up simulations #456
clean up simulations #456
Conversation
Code Coverage Summary
Diff against main
Results for commit: 0b08bd6 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Apologies @clarkliming for the delayed review, will do this tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so much simpler. Thanks a lot @clarkliming !!
Unit Tests Summary 1 files 46 suites 23s ⏱️ Results for commit 0b08bd6. |
there are just too many updates done within this merge request, @danielinteractive please have a careful review.
The reason to have this is to achieve smooth simulation. The changes (and reasons) are listed as below
~ visit|id