Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visR namespace to step_ribbon function call re issue #449 #450

Merged
merged 3 commits into from
Aug 5, 2022

Conversation

bailliem
Copy link
Collaborator

@bailliem bailliem commented Aug 5, 2022

What changes are proposed in this pull request?

Add visR namespace to step_ribbon function call.
Add experimental lifecycle to current version of add_CI() due to extension with ribbon.

Which files are involved in this pull request and what changes were made?

  • add_CI.R
  • stat_stepribbon.R

Did you include unit tests for the proposed change/bug fix (https://testthat.r-lib.org/)?

Add this to issue #443

If there is an GitHub issue associated with this pull request, please provide link.

#449

Checklist for PR reviewer

  • PR branch has pulled the most recent updates from main branch. Ensure the pull request branch and your local version match and both have the latest updates from the main branch.
  • If a new function was added, function should be included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report()). Before you run, begin a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • Has NEWS.md been updated with the changes from this pull request under the heading indicating the latest version. If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Has the version number been incremented using usethis::use_version(which = "dev")
  • Run devtools::build_readme() to build the README.md file.
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@bailliem bailliem mentioned this pull request Aug 5, 2022
12 tasks
Copy link
Collaborator Author

@bailliem bailliem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

@bailliem bailliem merged commit f20aee3 into main Aug 5, 2022
@bailliem bailliem deleted the bug/449-ribbon branch August 5, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant