Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor filter/filter_with_hvg #251

Closed
rcannood opened this issue Jan 17, 2023 · 0 comments · Fixed by #667
Closed

Refactor filter/filter_with_hvg #251

rcannood opened this issue Jan 17, 2023 · 0 comments · Fixed by #667
Labels
enhancement New feature or request

Comments

@rcannood
Copy link
Contributor

I think filter/filter_with_hvg is a misnomer because typically you don't want this component to filter, only annotate.

In addition, any references to "genes" should be renamed to features or vars.

Proposal:

highly_variable/highly_variable_scanpy/config.vsh.yaml:

functionality:
  name: highly_variable_scanpy
  namespace: highly_variable
  ...
  arguments:
    ...
    - name: "--var_name_filter"
      type: string
      default: "highly_variable"
      description: In which .var slot to store a boolean array corresponding to which features are highly variable.
    - name: "--varm_name"
      type: string
      default: "highly_variable"
      description: In which .varm slot to store additional output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant