Skip to content

Conversation

DriesSchaumont
Copy link
Member

@DriesSchaumont DriesSchaumont commented Jan 24, 2024

Changelog

Refactor filter_with_hvg to highly_variable_features_scanpy

Issue ticket number and link

Closes #251 (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont linked an issue Jan 24, 2024 that may be closed by this pull request
@DriesSchaumont
Copy link
Member Author

@DriesSchaumont DriesSchaumont marked this pull request as ready for review January 24, 2024 14:10
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions

Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
@DriesSchaumont DriesSchaumont merged commit ace541a into main Jan 26, 2024
@DriesSchaumont DriesSchaumont deleted the 251-refactor-filterfilter_with_hvg branch January 31, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor filter/filter_with_hvg
2 participants