Skip to content

Commit

Permalink
Remove antiquated code that can cause problems
Browse files Browse the repository at this point in the history
Now that hwloc is providing better definition of
"allowed" cpus, we no longer want/need to be
doing an explicit read of the local affinity.
This was incorrectly being applied to all
daemons because we assumed that any externally
applied binding (e.g., cgroup) would apply to
all locations - mpirun as well as compute
nodes. Sometimes isn't true, so just avoid
the complications.

Signed-off-by: Ralph Castain <rhc@pmix.org>
  • Loading branch information
rhc54 committed Feb 9, 2023
1 parent 2844e03 commit 5712e2e
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/hwloc/hwloc_base_util.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,6 @@ hwloc_cpuset_t prte_hwloc_base_setup_summary(hwloc_topology_t topo)
hwloc_cpuset_t avail = NULL;

avail = hwloc_bitmap_alloc();
/* get the cpus we are bound to */
if (!prte_hwloc_synthetic_topo &&
0 <= hwloc_get_cpubind(topo, avail, HWLOC_CPUBIND_PROCESS)) {
return avail;
}

/* get the root available cpuset */
#if HWLOC_API_VERSION < 0x20000
Expand Down

0 comments on commit 5712e2e

Please sign in to comment.