Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / ReferencePushPullFeeder smarter Auto-Setup #1450

Merged

Conversation

markmaker
Copy link
Collaborator

@markmaker markmaker commented Jul 23, 2022

Description

With help from Jan and vespaman from the discussion list, the ReferencePushPullFeeder pipeline handling and Auto-Setup was improved.

  1. There are now two stock pipelines shipped, the classic one for color-keyed feeders ("green-screening") and a new one that tries to detect the sprocket holes using the circular symmetry stage.
  2. The pipeline type is automatically selected in Auto-Setup (tries types until successful).
  3. The user can also manually select and reset to the pipeline type in the Wizard.
  4. The pipeline type is cloned along with the pipeline.
  5. Auto-Setup now suppresses detected hole lines that are too close to the pick location. If the stage mistakenly detects the pockets as sprocket holes (which can happen with 0402 pockets, which have an unfortunate "tangential" likeness), this line is robustly rejected (by EIA-481 the sprocket line must nominally be at least 3.5mm away from the pick location, this is checked with tolerance).
  6. A bug in the selection loop was fixed, now the closest (remaining) line is robustly favored, i.e. neighboring feeders' sprocket holes will be rejected.
  7. Vision failure is indicated with a crossed-out result view. Therefore, pressing Vision Preview will now always give feedback.

Justification

ReferencePushPullFeeder is increasingly used for drag feeders, mostly on CHMT machines, where the feeders aren't color-keyed. Auto-Setup did not work out of the box, users needed to copy and paste a special pipeline, and then it still mistook pockets as sprocket holes, as shown here (image by vespaman):

grafik

See this discussion:
https://groups.google.com/g/openpnp/c/N6IVhO_xbrw/m/vw-xOUtzBQAJ

Instructions for Use

The Wiki has been updated, see:

Vision Type Tooltip

Implementation Details

  1. Tested in simulation.
  2. Did follow the coding style.
  3. No changes in the org.openpnp.spi or org.openpnp.model packages.
  4. Successful mvn test before submitting the Pull Request.

@markmaker markmaker merged commit e12475a into openpnp:test Jul 23, 2022
@markmaker markmaker deleted the feature/push-pull-feeder-smarter-auto-setup branch July 23, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant