Feature / ReferencePushPullFeeder smarter Auto-Setup #1450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With help from Jan and vespaman from the discussion list, the
ReferencePushPullFeeder
pipeline handling and Auto-Setup was improved.Justification
ReferencePushPullFeeder
is increasingly used for drag feeders, mostly on CHMT machines, where the feeders aren't color-keyed. Auto-Setup did not work out of the box, users needed to copy and paste a special pipeline, and then it still mistook pockets as sprocket holes, as shown here (image by vespaman):See this discussion:
https://groups.google.com/g/openpnp/c/N6IVhO_xbrw/m/vw-xOUtzBQAJ
Instructions for Use
The Wiki has been updated, see:
Implementation Details
org.openpnp.spi
ororg.openpnp.model
packages.mvn test
before submitting the Pull Request.