Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / ReferencePushPullFeeder Auto-Setup More Robust. #1457

Merged

Conversation

markmaker
Copy link
Collaborator

Description

  • Make ReferencePushPullFeeder Auto-Setup more robust by allowing interrupted sprocket hole lines.
  • Option for Ransac to search for interrupted lines.
  • Improve the stock ReferencePushPullFeeder circular symmetry pipeline to use Feature / More Robust Circular Symmetry Detection #1456.
  • Bonus: Fixed a bug in the fiducial test pipeline editing handler (Asking "Do you want to null?" and pressing Yes would throw).

Justification

See discussion:
https://groups.google.com/g/openpnp/c/N6IVhO_xbrw/m/PSOT0qaaAQAJ

Instructions for Use

See #1450 for usage. See also #1456 for inside details.

push-pull-feeder1659133317901680400

Implementation Details

  1. Tested with user images.
  2. Did follow the coding style.
  3. No changes in the org.openpnp.spi or org.openpnp.model packages.
  4. Successful mvn test before submitting the Pull Request.

…rupted sprocket hole lines.

Fix a bug in the fiducial test pipeline editing handler.
Adapt the ReferencePushPullFeeder circular symmetry pipeline.
@markmaker markmaker merged commit 365ada5 into openpnp:test Jul 29, 2022
@markmaker markmaker deleted the fix/push-pull-feeder-more-robust-auto-setup branch July 29, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant