Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to assign valuators to a category #28

Merged
merged 11 commits into from
Jan 8, 2023

Conversation

antopalidi
Copy link
Member

@antopalidi antopalidi commented Dec 20, 2022

fixes #25

  • overrides
  • tests

image

@antopalidi antopalidi added REF32 and removed REF32 labels Dec 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Base: 96.57% // Head: 94.13% // Decreases project coverage by -2.43% ⚠️

Coverage data is based on head (232cbf5) compared to base (3115db0).
Patch coverage: 82.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   96.57%   94.13%   -2.44%     
==========================================
  Files          27       34       +7     
  Lines         496      580      +84     
==========================================
+ Hits          479      546      +67     
- Misses         17       34      +17     
Impacted Files Coverage Δ
...orting_proposals/admin/update_category_override.rb 52.94% <52.94%> (ø)
...orting_proposals/admin/create_category_override.rb 56.25% <56.25%> (ø)
...eporting_proposals/admin/category_form_override.rb 88.88% <88.88%> (ø)
lib/decidim/reporting_proposals/engine.rb 97.77% <93.75%> (-2.23%) ⬇️
..._proposals/admin/categories_controller_override.rb 100.00% <100.00%> (ø)
...s/decidim/reporting_proposals/category_override.rb 100.00% <100.00%> (ø)
...roposals/participatory_space_user_role_override.rb 100.00% <100.00%> (ø)
...s/decidim/reporting_proposals/category_valuator.rb 100.00% <100.00%> (ø)
lib/decidim/reporting_proposals/admin_engine.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow admins to assign valuators to a category
3 participants