Change method scope to support extending module classes #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## integration #465 +/- ##
==============================================
Coverage 49.36% 49.36%
Complexity 969 969
==============================================
Files 55 55
Lines 7666 7666
Branches 1392 1392
==============================================
Hits 3784 3784
Misses 3422 3422
Partials 460 460
Continue to review full report at Codecov.
|
carlwilson
added
feature
tledoux
reviewed
Oct 25, 2019
| */ | ||
| private boolean isPropertyEmpty (Property property, PropertyArity arity) { | ||
| public boolean isPropertyEmpty (Property property, PropertyArity arity) { |
There was a problem hiding this comment.
Shouldn't this method be static also ?
| * @param uri | ||
| * @return | ||
| */ | ||
| public String cleanURIString (String uri) { |
There was a problem hiding this comment.
Shouldn't this method be static ?
|
I'd not thought that clearly about it before @tledoux but I think you're right. Will pr a refactor. |
|
Included in #538 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portico is working to upgrade to 1.23 - we currently use a modified older version of JHOVE. There are several method/property scope changes would that allow us to continue to use some local module extensions without having to maintain a customized version of JHOVE. If they are benign (or even useful) for other users, it would be great if we could merge these.
Question for reviewer(s): one of the changes is in the
xml-hulmodule. Should I increment the version? and if so to a SNAPSHOT version?Thanks!