Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX - Message constant niggles #499

Merged
merged 6 commits into from
Oct 21, 2019
Merged

FIX - Message constant niggles #499

merged 6 commits into from
Oct 21, 2019

Conversation

carlwilson
Copy link
Member

  • added message properties file for core constants;
  • corrected missed concatenation from PDF-HUL-3;
  • added exception message to creation of PDF-HUL-3 in Destination; and
  • removed Java punctuation from ASCII-HUL-1-SUB.

@carlwilson
FIX - Message constant niggles
b978546 
- added message properties file for core constants;
- corrected missed concatenation from `PDF-HUL-3`;
- added exception message to creation of `PDF-HUL-3` in `Destination`; and
- removed Java punctuation from `ASCII-HUL-1-SUB`.
@carlwilson carlwilson added bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release hacktoberfest labels Oct 18, 2019
@carlwilson carlwilson added this to the Doc hack week October 2019 milestone Oct 18, 2019
@carlwilson carlwilson self-assigned this Oct 18, 2019
@carlwilson
FIX - Concatenated core messages
03ad17f 
- fixed concatenation issue for core messages based on `EXC_PROP_CLSS_INCMPT`;
- removed concatenation from unused property file and to be refactored `CoreMessageConstants` class; and
- used string formatting to replace concatenation and avoid redundancy.
@codecov
Copy link

codecov bot commented Oct 18, 2019 •
edited

Codecov Report

Merging #499 into integration will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #499      +/-   ##
=================================================
- Coverage          49.54%   49.51%   -0.03%     
  Complexity           974      974              
=================================================
  Files                 55       55              
  Lines               7666     7670       +4     
  Branches            1392     1392              
=================================================
  Hits                3798     3798              
- Misses              3412     3416       +4     
  Partials             456      456
Impacted Files Coverage Δ Complexity Δ
...du/harvard/hul/ois/jhove/CoreMessageConstants.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../main/java/edu/harvard/hul/ois/jhove/Property.java 42.42% <0%> (-2.74%) 16 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f9d93...aee4301. Read the comment docs.

tledoux
tledoux approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@tledoux tledoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlwilson carlwilson merged commit 65956e5 into integration Oct 21, 2019
@carlwilson carlwilson deleted the refact/core-errors branch October 21, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tledoux tledoux tledoux approved these changes

Assignees

@carlwilson carlwilson

Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlwilson @tledoux