-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX - Message constant niggles #499
Conversation
- added message properties file for core constants; - corrected missed concatenation from `PDF-HUL-3`; - added exception message to creation of `PDF-HUL-3` in `Destination`; and - removed Java punctuation from `ASCII-HUL-1-SUB`.
- fixed concatenation issue for core messages based on `EXC_PROP_CLSS_INCMPT`; - removed concatenation from unused property file and to be refactored `CoreMessageConstants` class; and - used string formatting to replace concatenation and avoid redundancy.
Codecov Report
@@ Coverage Diff @@
## integration #499 +/- ##
=================================================
- Coverage 49.54% 49.51% -0.03%
Complexity 974 974
=================================================
Files 55 55
Lines 7666 7670 +4
Branches 1392 1392
=================================================
Hits 3798 3798
- Misses 3412 3416 +4
Partials 456 456
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PDF-HUL-3
;PDF-HUL-3
inDestination
; andASCII-HUL-1-SUB
.