-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reno ci #506
Add reno ci #506
Conversation
The test is to make sure it fails CI until I add a reno. |
Confirmed this is behaving as expected and ready for review:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I suggested a few things that seemed like small improvements to me.
When I run reno report
it generates a report for ast-py/v0.5.0-19
which is rather odd. Partially this is because of the old tag names in the repository, but I'm not sure what the -19
is about. Can we do anything about this in this PR? Or do we just need to fix things when we sort out the release process itself?
Reno report looks ok for me.
|
@taalexander Approved. Could you tell me a bit more about how you ran |
I just ran it with
|
I'll need another approving review to merge it seems. |
I saw this as well. Just tinkering with things, I noticed that when I added a commit, the number got incremented. When I added a dummy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this.
Summary
Are you changing the specification? This PR needs to be approved by the TSC members.
No
Are you changing the grammar to adjust to the specification?
No
Details and comments
Closes #328