Reno: only require release notes in changes to source directory
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braised-babbage
force-pushed
the
source-only-for-release-notes
branch
from
03853f6
to
2e1ee24
Compare
taalexander
reviewed
Jan 23, 2024
Ok, I tried it out, and saw the following failure (as expected) https://github.com/openqasm/openqasm/actions/runs/7631739064/job/20790381370. I've reverted the change in my latest commit. |
|
failing CI for an example of why we need this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #506 we started using Reno for managing release notes. Along with this is check that notes are provided when there is a
git diff. This PR tweaks that to only check for changes to thesourcedirectory (i.e. changes to the spec or parser & reference AST). My reasoning is that we do not need to provide release notes for changes to things like GitHub actions, project README, etc, so this check should make an effort to ignore such changes.