New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the building the manual with a Visual Studio Code development container #557
Conversation
- Pull request #525 at 614b222: TCS extensions - Pull request #527 at fac005e: Brake cuts power refactor and new parameters - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 3135da4: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #548 at eb4b560: Links to dead Siskiyou site removed - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at fbb4773: Improve memory statistics for CPU and GPU - Pull request #557 at 2f7b7d4: Add support for the building the manual with a Visual Studio Code development container
2f7b7d4
to
f931073
Compare
- Pull request #525 at 614b222: TCS extensions - Pull request #527 at fac005e: Brake cuts power refactor and new parameters - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 3135da4: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #548 at eb4b560: Links to dead Siskiyou site removed - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at fbb4773: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container
- Pull request #525 at 614b222: TCS extensions - Pull request #527 at fac005e: Brake cuts power refactor and new parameters - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 3135da4: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at fbb4773: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #558 at 68a8700: Revised Visual Studio version
Hi Ryan,
This sounds so much better than what we're currently doing. Many thanks. Will try it as soon as i have a moment.
Thanks for suggesting a workaround, but I would argue against something that divorced the Manual from the code. At present, changes to the Manual are the first item on my checklist when reviewing a code PR. If they're in a different repository, I expect they would often be skipped. |
- Pull request #525 at 614b222: TCS extensions - Pull request #527 at fac005e: Brake cuts power refactor and new parameters - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 3135da4: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #558 at 68a8700: Revised Visual Studio version
- Pull request #525 at 614b222: TCS extensions - Pull request #527 at fac005e: Brake cuts power refactor and new parameters - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 3135da4: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #558 at 68a8700: Revised Visual Studio version - Pull request #559 at aaeb251: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls
- Pull request #525 at 614b222: TCS extensions - Pull request #527 at fac005e: Brake cuts power refactor and new parameters - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 3135da4: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #558 at 68a8700: Revised Visual Studio version - Pull request #559 at 9e80053: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls - Pull request #560 at 46a143d: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich
- Pull request #525 at 614b222: TCS extensions - Pull request #527 at fac005e: Brake cuts power refactor and new parameters - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at febc605: Initial Virtual File System development - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #559 at 9e80053: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls - Pull request #560 at 46a143d: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at febc605: Initial Virtual File System development - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #559 at 9e80053: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls - Pull request #560 at 46a143d: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #541 at febc605: Initial Virtual File System development - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #559 at 9e80053: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls - Pull request #560 at 46a143d: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #541 at febc605: Initial Virtual File System development - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #559 at 9e80053: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls - Pull request #560 at 46a143d: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907 - Pull request #562 at 44f35b4: Remove the locomotive handle from the script, because no interface function can allow access to any internal structure.
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #541 at febc605: Initial Virtual File System development - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #559 at 9e80053: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls - Pull request #560 at 46a143d: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907 - Pull request #562 at 44f35b4: Remove the locomotive handle from the script, because no interface function can allow access to any internal structure. - Pull request #563 at 9f1cd64: Correct a timing issue in Eames brakes
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #541 at febc605: Initial Virtual File System development - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #559 at 9e80053: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls - Pull request #560 at 46a143d: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907 - Pull request #562 at 44f35b4: Remove the locomotive handle from the script, because no interface function can allow access to any internal structure. - Pull request #563 at 9f1cd64: Correct a timing issue in Eames brakes - Pull request #565 at ebcd9e8: Correct Steam locomoti starting tractive effort.
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #541 at febc605: Initial Virtual File System development - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #559 at 9e80053: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls - Pull request #560 at 46a143d: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907 - Pull request #562 at 44f35b4: Remove the locomotive handle from the script, because no interface function can allow access to any internal structure. - Pull request #563 at 9f1cd64: Correct a timing issue in Eames brakes - Pull request #565 at ebcd9e8: Correct Steam locomoti starting tractive effort. - Pull request #566 at b022de2: Fix for https://bugs.launchpad.net/or/+bug/1956262. F5 causes OR crash.
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #541 at febc605: Initial Virtual File System development - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #559 at 9e80053: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls - Pull request #560 at 46a143d: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907 - Pull request #562 at 44f35b4: Remove the locomotive handle from the script, because no interface function can allow access to any internal structure. - Pull request #563 at 9f1cd64: Correct a timing issue in Eames brakes - Pull request #565 at ebcd9e8: Correct Steam locomoti starting tractive effort. - Pull request #566 at 04d1bb7: Fix for https://bugs.launchpad.net/or/+bug/1956262. F5 causes OR crash.
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #541 at febc605: Initial Virtual File System development - Pull request #545 at d85b4ed: Fix VRAM usage - Pull request #551 at 0aa1e46: Make handling the timetable-or extension consistent. - Pull request #554 at 3329168: Bug fix for Crash when switching cabs and changing screen page https://bugs.launchpad.net/or/+bug/1955575 - Pull request #555 at 5270648: Bug fix for crash with diesel locos with more than an engine, https://bugs.launchpad.net/or/+bug/1955582 - Pull request #556 at afe2069: Improve memory statistics for CPU and GPU - Pull request #557 at f931073: Add support for the building the manual with a Visual Studio Code development container - Pull request #559 at 9e80053: https://blueprints.launchpad.net/or/+spec/distributed-power: Distributed power cab display and controls - Pull request #560 at 46a143d: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907 - Pull request #562 at 44f35b4: Remove the locomotive handle from the script, because no interface function can allow access to any internal structure. - Pull request #563 at 59a0e1c: Correct a timing issue in Eames brakes - Pull request #565 at ebcd9e8: Correct Steam locomoti starting tractive effort. - Pull request #566 at 04d1bb7: Fix for https://bugs.launchpad.net/or/+bug/1956262. F5 causes OR crash.
Hi Ryan, All worked well for me. I've added some extra notes below for anyone else who wants to try it.
In my case, installing Docker Desktop also prompted for the WSL 2 Linux kernel.
It's "Remote-Containers: Open Folder in Container"
Ctrl+Shift+B is a shortcut for running the default task in the Terminal window, in this case "make html" and you can browse the results at "Source\Documentation\Manual_build\html\index.html" In the Terminal window, enter "make latexpdf" to build "Source\Documentation\Manual_build\latex\Manual.pdf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works very well. No issues.
Approved with thanks,
Chris
Visual Studio Code's development containers feature allows us to construct a reproducible, well-defined Linux toolstack to work with our code on our Windows machines. It's the perfect technology to apply to our manual; rather than installing and maintaining the full Python/Sphinx/LaTeX stack, you can let VS Code and Docker do all the work for you!
To use the feature:
This will hopefully make it much easier for other developers and interested power users to contribute to our manual.
Caveat: You're normally able to use VS Code's Git integration in a development container, but it doesn't work for our use case. That's because the manual is located in a subdirectory, and VS Code doesn't yet detect development container workspaces within subdirectories (microsoft/vscode-remote-release#2413), so you can't open the openrails root folder and get full Git integration. One possible workaround would be to spin off the manual to separate repository, as we are doing for the website.