C# signal script extensions #537

Sharpe49 · 2021-11-23T14:46:07Z

https://blueprints.launchpad.net/or/+spec/csharp-signal-script-extensions
https://blueprints.launchpad.net/or/+spec/override-speed-limit-from-csharp-signal-scripts

- Pull request #510 at ca2494d: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 46567ee: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #534 at ba3f85a: deletes RunActivityLAA.* post-build - Pull request #537 at 2fbbe40: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #539 at fd04274: Correct starting tractive force of steam locomotive

- Pull request #510 at ca2494d: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 46567ee: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #534 at ba3f85a: deletes RunActivityLAA.* post-build - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #539 at fd04274: Correct starting tractive force of steam locomotive

- Pull request #510 at d73cb10: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 46567ee: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #534 at ba3f85a: deletes RunActivityLAA.* post-build - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #539 at fd04274: Correct starting tractive force of steam locomotive

- Pull request #510 at d73cb10: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #534 at ba3f85a: deletes RunActivityLAA.* post-build - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #539 at fd04274: Correct starting tractive force of steam locomotive

- Pull request #510 at fa2c10d: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #534 at ba3f85a: deletes RunActivityLAA.* post-build - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #539 at fd04274: Correct starting tractive force of steam locomotive

- Pull request #510 at fa2c10d: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #534 at ba3f85a: deletes RunActivityLAA.* post-build - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #539 at fd04274: Correct starting tractive force of steam locomotive - Pull request #540 at 8711c47: Correct issue created in timetable mode

- Pull request #510 at ded7bd3: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #539 at fd04274: Correct starting tractive force of steam locomotive

- Pull request #510 at 87f621f: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #539 at fd04274: Correct starting tractive force of steam locomotive

- Pull request #510 at 87f621f: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs

- Pull request #510 at ede95f0: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs

- Pull request #510 at 7cadc9f: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 265b635: Fix VRAM usage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 564ae46: Fix VRAM usage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 1b818ae: Fix VRAM usage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at 57e5143: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 1b818ae: Fix VRAM usage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 884b139: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 1b818ae: Fix VRAM usage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 1b818ae: Fix VRAM usage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 23dfa3f: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 1b818ae: Fix VRAM usage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 23dfa3f: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 32b8d28: Fix VRAM usage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at e26a9b4: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 32b8d28: Fix VRAM usage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at a74d7b8: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 32b8d28: Fix VRAM usage

- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at a74d7b8: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 6bf8ab2: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 32b8d28: Fix VRAM usage

cesarBLG

Thanks for this useful additions to signal scripts!
I reviewed the PR commit by commit, but I didn't had a deep look into refactoring commits, as they are huge. I assume they are only moving things around and reformatting the code.
I didn't spot more issues, so I'm approving. This has been around for quite a long time.

- Pull request #537 at 7d3db52: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at bf98bf7: Container loaded wagons in Multiplayer mode

- Pull request #537 at 7d3db52: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at bf98bf7: Container loaded wagons in Multiplayer mode

Sharpe49 · 2022-08-18T01:13:54Z

@cesarBLG Well, I have to rebase once more since there is a conflict... ;)

…d signal functions, signal object types and signal speed info Fixed display of SPEED signals on track monitor

- Pull request #537 at 939b2b2: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at bf98bf7: Container loaded wagons in Multiplayer mode

- Pull request #537 at 939b2b2: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at bf98bf7: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state

cesarBLG

OK, I'm merging before more conflicts arise

cesarBLG · 2022-08-18T21:03:53Z

I tested a different route and I'm getting some null reference exceptions:
SignalObject.cs:97

if (SignalHeads.Exists(x => x.Function.MstsFunction != MstsSignalFunction.SPEED))

It crashes during startup. Changing to Function?.MstsFunction solves the issue, but I believe Function should always be non-null.

Also, NextSpeedPostFeatures returns a null SpeedPostTypeName.

Probably this is caused by errors in the route, but it used to work.

Sharpe49 · 2022-08-19T02:09:36Z

I will take a look at it.

Sharpe49 · 2022-08-19T16:17:52Z

@cesarBLG Can you send a log when it fails?

Sharpe49 · 2022-08-20T13:06:36Z

@cesarBLG It was for this PR that I needed some log. ;)

cesarBLG · 2022-08-22T08:44:39Z

Oops, I thought it was for the other PR. Here you are:
OpenRailsLog.txt

Sharpe49 · 2022-08-22T17:44:45Z

You have a missing signal type (etcs_estacion_pere_comas) and a lot of weird things in your SIGSCR. Can you check it?
Maybe the new code is less tolerant to SIGCFG errors.

cesarBLG · 2022-08-23T08:46:17Z

There was a phantom signal or something like that. Removing it solves the null pointer error at SignalFunction.

I am still investigating why SpeedPostFeatures.SpeedPostTypeName is null, as everything seems correct with that speedpost.

cesarBLG · 2022-08-23T09:36:46Z

It seems that AddWorldInfo() is calling the signal.Type property, which internally requires signal.SpeedPostWorldObject to be initialized. However, the initialization of signal.SpeedPostWorldObject only happens in AddWorldInfo() after the signal.Type property is checked. This results in an incorrectly initialized speed post.

Sharpe49 changed the title ~~C# script extensions~~ C# signal script extensions Nov 23, 2021

Sharpe49 added enhancement New feature or request refactoring Changes with minimal user-visible effects labels Nov 23, 2021

Sharpe49 force-pushed the csharp-script-extensions branch from 5d1501a to 2fbbe40 Compare November 23, 2021 22:56

Sharpe49 force-pushed the csharp-script-extensions branch from 2fbbe40 to e753905 Compare November 30, 2021 01:44

cesarBLG previously approved these changes Aug 17, 2022

View reviewed changes

Sharpe49 added 9 commits August 18, 2022 03:16

Classes moved to separate files and code cleanup

bfdfae1

Cleanup: Replace signalObjects by an auto-property

35ea800

Moved signals initialization after world info addition

6553f9a

Added signal shape name to the C# signal script interface

b507ea5

More cleanup

01365cf

Code cleanup before modification

883b932

Add HoldState and HandleEvent to C# signal scripts (and refactoring)

27bfb9b

Show signalling debug information for all signal types

f8ecd7b

Added C# signal script functions for setting speed info and refactore…

939b2b2

…d signal functions, signal object types and signal speed info Fixed display of SPEED signals on track monitor

Sharpe49 dismissed cesarBLG’s stale review via 939b2b2 August 18, 2022 01:19

Sharpe49 force-pushed the csharp-script-extensions branch from 7d3db52 to 939b2b2 Compare August 18, 2022 01:19

cesarBLG approved these changes Aug 18, 2022

View reviewed changes

cesarBLG merged commit 678a674 into openrails:master Aug 18, 2022

Sharpe49 deleted the csharp-script-extensions branch August 19, 2022 01:12

Sharpe49 mentioned this pull request Aug 24, 2022

Fix for crash during signal loading #700

Merged

cesarBLG mentioned this pull request Sep 18, 2022

Search for NORMAL signals if no argument is provided #712

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C# signal script extensions #537

C# signal script extensions #537

Sharpe49 commented Nov 23, 2021 •

edited

cesarBLG left a comment

Sharpe49 commented Aug 18, 2022 •

edited

cesarBLG left a comment

cesarBLG commented Aug 18, 2022

Sharpe49 commented Aug 19, 2022 •

edited

Sharpe49 commented Aug 19, 2022

Sharpe49 commented Aug 20, 2022

cesarBLG commented Aug 22, 2022

Sharpe49 commented Aug 22, 2022

cesarBLG commented Aug 23, 2022

cesarBLG commented Aug 23, 2022

C# signal script extensions #537

C# signal script extensions #537

Conversation

Sharpe49 commented Nov 23, 2021 • edited

cesarBLG left a comment

Choose a reason for hiding this comment

Sharpe49 commented Aug 18, 2022 • edited

cesarBLG left a comment

Choose a reason for hiding this comment

cesarBLG commented Aug 18, 2022

Sharpe49 commented Aug 19, 2022 • edited

Sharpe49 commented Aug 19, 2022

Sharpe49 commented Aug 20, 2022

cesarBLG commented Aug 22, 2022

Sharpe49 commented Aug 22, 2022

cesarBLG commented Aug 23, 2022

cesarBLG commented Aug 23, 2022

Sharpe49 commented Nov 23, 2021 •

edited

Sharpe49 commented Aug 18, 2022 •

edited

Sharpe49 commented Aug 19, 2022 •

edited