Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded project files to .Net SDK project file format #569

Merged
merged 5 commits into from Aug 7, 2022

Conversation

Sharpe49
Copy link
Contributor

@Sharpe49 Sharpe49 commented Jan 9, 2022

Removed AssemblyInfo files (integrated in the project file)
Removed unused files (not referenced in the old project files)
Removed resource files in ActivityEditor which were causing execution problems

1st step of https://blueprints.launchpad.net/or/+spec/dependencies-update
http://www.elvastower.com/forums/index.php?/topic/32819-upgrading-net-c/page__view__findpost__p__278324

@Sharpe49 Sharpe49 added the enhancement New feature or request label Jan 9, 2022
@cjakeman
Copy link
Contributor

cjakeman commented Feb 5, 2022

Hi Cedric,

The Code Bot at https://james-ross.co.uk/projects/or reports a merge/delete conflict for Source/Orts.Simulation/packages.config

Are you able to sort this out?

Thanks,

Chris

@Sharpe49
Copy link
Contributor Author

Sharpe49 commented Feb 5, 2022

That's to be expected. The packages.config will be deleted (its information are now integrated in the csproj file) while another pull request wants to modify the packages.config file (it should be the script compiler pull request).

@Sharpe49 Sharpe49 force-pushed the dotnetsdk-project-files-upgrade branch from 9b757a1 to 347b3df Compare August 3, 2022 22:05
twpol pushed a commit that referenced this pull request Aug 3, 2022
- Pull request #525 at 614b222: TCS extensions
- Pull request #569 at 347b3df: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #669 at 1ab5f58: refactor: Separate host performance data collection and processing to another thread
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #672 at e4ba722: Calculate distance to signal in explorer mode
- Pull request #673 at 3080e85: hu locales update
@Sharpe49
Copy link
Contributor Author

Sharpe49 commented Aug 3, 2022

Ok, rebased my branch and taking it out of draft.

@Sharpe49 Sharpe49 marked this pull request as ready for review August 3, 2022 22:12
twpol pushed a commit that referenced this pull request Aug 3, 2022
- Pull request #569 at 347b3df: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #669 at 1ab5f58: refactor: Separate host performance data collection and processing to another thread
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #672 at e4ba722: Calculate distance to signal in explorer mode
- Pull request #673 at 3080e85: hu locales update
twpol pushed a commit that referenced this pull request Aug 3, 2022
- Pull request #569 at 686d0ba: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #669 at 1ab5f58: refactor: Separate host performance data collection and processing to another thread
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #672 at e4ba722: Calculate distance to signal in explorer mode
- Pull request #673 at 3080e85: hu locales update
twpol pushed a commit that referenced this pull request Aug 4, 2022
- Pull request #569 at 686d0ba: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #669 at 1ab5f58: refactor: Separate host performance data collection and processing to another thread
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #672 at e4ba722: Calculate distance to signal in explorer mode
- Pull request #673 at 3080e85: hu locales update
- Pull request #674 at e160e26: Mark particle drawer texture for wagons
@Sharpe49 Sharpe49 force-pushed the dotnetsdk-project-files-upgrade branch 2 times, most recently from a981086 to 7e31427 Compare August 4, 2022 11:51
twpol pushed a commit that referenced this pull request Aug 4, 2022
- Pull request #569 at a981086: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #669 at 1ab5f58: refactor: Separate host performance data collection and processing to another thread
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #673 at 3080e85: hu locales update
- Pull request #674 at e160e26: Mark particle drawer texture for wagons
@Sharpe49 Sharpe49 force-pushed the dotnetsdk-project-files-upgrade branch from 7e31427 to 4c5b3b2 Compare August 4, 2022 11:58
twpol pushed a commit that referenced this pull request Aug 4, 2022
- Pull request #569 at 4c5b3b2: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #669 at 1ab5f58: refactor: Separate host performance data collection and processing to another thread
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #673 at 3080e85: hu locales update
- Pull request #674 at e160e26: Mark particle drawer texture for wagons
@Sharpe49
Copy link
Contributor Author

Sharpe49 commented Aug 4, 2022

Unstable builds are failing because other branches are adding files to the csproj files, which is forbidden.

@Sharpe49 Sharpe49 added the not-for-unstable Special label to exclude a pull request from the Unstable Version label Aug 4, 2022
@cjakeman cjakeman requested a review from twpol August 5, 2022 19:09
@cjakeman cjakeman removed the not-for-unstable Special label to exclude a pull request from the Unstable Version label Aug 6, 2022
twpol pushed a commit that referenced this pull request Aug 6, 2022
- Pull request #569 at 4c5b3b2: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #665 at 5956412: 02n: Removes some redundant experimental options
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #673 at 3080e85: hu locales update
- Pull request #674 at e160e26: Mark particle drawer texture for wagons
twpol pushed a commit that referenced this pull request Aug 6, 2022
- Pull request #569 at 2448c4a: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #665 at 5956412: 02n: Removes some redundant experimental options
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #673 at 3080e85: hu locales update
- Pull request #674 at e160e26: Mark particle drawer texture for wagons
@Sharpe49 Sharpe49 force-pushed the dotnetsdk-project-files-upgrade branch from 2448c4a to efd9055 Compare August 7, 2022 01:10
@Sharpe49
Copy link
Contributor Author

Sharpe49 commented Aug 7, 2022

I prefer rebasing instead of merging when we are in a branch. It makes the history easier to understand.

Removed AssemblyInfo files (integrated in the project file)
Removed unused files (not referenced in the old project files)
Removed resource files in ActivityEditor which were causing execution problems
@Sharpe49 Sharpe49 force-pushed the dotnetsdk-project-files-upgrade branch from efd9055 to e51497d Compare August 7, 2022 01:19
twpol pushed a commit that referenced this pull request Aug 7, 2022
- Pull request #569 at e51497d: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #665 at 5956412: 02n: Removes some redundant experimental options
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #673 at 3080e85: hu locales update
- Pull request #674 at e160e26: Mark particle drawer texture for wagons
twpol pushed a commit that referenced this pull request Aug 7, 2022
- Pull request #569 at e51497d: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #665 at 5956412: 02n: Removes some redundant experimental options
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #673 at 3080e85: hu locales update
- Pull request #674 at e160e26: Mark particle drawer texture for wagons
- Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible
twpol pushed a commit that referenced this pull request Aug 7, 2022
- Pull request #569 at e51497d: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #665 at 5956412: 02n: Removes some redundant experimental options
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #673 at 3080e85: hu locales update
- Pull request #674 at e160e26: Mark particle drawer texture for wagons
- Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible
- Pull request #676 at 7687cb8: adds content hosted on GitHub.com
twpol pushed a commit that referenced this pull request Aug 7, 2022
- Pull request #569 at e51497d: Upgraded project files to .Net SDK project file format
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #665 at 5956412: 02n: Removes some redundant experimental options
- Pull request #671 at c5dcc73: Updates manual for Release 1.5
- Pull request #673 at 3080e85: hu locales update
- Pull request #674 at e160e26: Mark particle drawer texture for wagons
- Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible
- Pull request #676 at 3ee0822: adds content hosted on GitHub.com
Copy link
Contributor

@cjakeman cjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Cedric,

This is large piece of work and I can't say I know enough to criticise it.

However it's been around long enough for any issues to show up so I'm approving and merging it.

Many thanks,

Chris

@cjakeman cjakeman merged commit 9e0e99a into openrails:master Aug 7, 2022
@Sharpe49 Sharpe49 deleted the dotnetsdk-project-files-upgrade branch August 8, 2022 07:32
Csantucci added a commit to Csantucci/openrails that referenced this pull request Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants