New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TrainCar part 1 #678
Conversation
Comparing "before" and "after" is going to be interesting. Hoping to see see what professional practice looks like, so thanks for sharing. |
This is simple extraction of repetitive data, but things will get more interesting with time :) |
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #680 at 2cae93d: build: Fix the file metadata after the .NET SDK project switch
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #680 at 2cae93d: build: Fix the file metadata after the .NET SDK project switch - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #680 at 2cae93d: build: Fix the file metadata after the .NET SDK project switch - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests - Pull request #682 at 7fb9de6: Updated links to Deco Games
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #680 at 2cae93d: build: Fix the file metadata after the .NET SDK project switch - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests - Pull request #682 at 7fb9de6: Updated links to Deco Games - Pull request #683 at 031b297: fix: Clean up Simulator Tester help output to match dotnet-style
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #680 at 2cae93d: build: Fix the file metadata after the .NET SDK project switch - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests - Pull request #682 at 7fb9de6: Updated links to Deco Games - Pull request #683 at 031b297: fix: Clean up Simulator Tester help output to match dotnet-style - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #680 at 2cae93d: build: Fix the file metadata after the .NET SDK project switch - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests - Pull request #682 at 7fb9de6: Updated links to Deco Games - Pull request #683 at 031b297: fix: Clean up Simulator Tester help output to match dotnet-style - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at 0db6d96: fix: Clean up Data Collector help output to match dotnet-style
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #680 at 2cae93d: build: Fix the file metadata after the .NET SDK project switch - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests - Pull request #682 at 7fb9de6: Updated links to Deco Games - Pull request #683 at 031b297: fix: Clean up Simulator Tester help output to match dotnet-style - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #687 at 2cbce1f: fix: Clean up Content Checker help output to match dotnet-style
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #680 at 2cae93d: build: Fix the file metadata after the .NET SDK project switch - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests - Pull request #682 at 7fb9de6: Updated links to Deco Games - Pull request #683 at 031b297: fix: Clean up Simulator Tester help output to match dotnet-style - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #687 at 2cbce1f: fix: Clean up Content Checker help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #570 at ad5a0d0: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests - Pull request #683 at 031b297: fix: Clean up Simulator Tester help output to match dotnet-style - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #687 at 2cbce1f: fix: Clean up Content Checker help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests - Pull request #683 at 031b297: fix: Clean up Simulator Tester help output to match dotnet-style - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #687 at 2cbce1f: fix: Clean up Content Checker help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #537 at e88581e: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests - Pull request #683 at 031b297: fix: Clean up Simulator Tester help output to match dotnet-style - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #687 at 2cbce1f: fix: Clean up Content Checker help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #537 at e88581e: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #681 at c5cc067: test: Fix tests when StfReader tests run before JsonReader tests - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #687 at 2cbce1f: fix: Clean up Content Checker help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #537 at e88581e: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at fd34961: Sync turntables and transfertables in multiplayer mode
- Pull request #537 at e88581e: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at fd34961: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used
- Pull request #537 at e88581e: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at fd34961: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5
- Pull request #537 at e88581e: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #675 at 9664141: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at fd34961: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0
- Pull request #537 at e88581e: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #675 at 4d79756: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at fd34961: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0
- Pull request #537 at 7d3db52: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #675 at 4d79756: Bug fix for https://bugs.launchpad.net/or/+bug/1983511 When an AI train disappears at end of run, containers remain visible - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at fd34961: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0
- Pull request #537 at 7d3db52: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 8eea009: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0
- Pull request #537 at 7d3db52: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 8eea009: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at bf98bf7: Container loaded wagons in Multiplayer mode
- Pull request #537 at 7d3db52: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #679 at 223aae6: Provide travelled distance to TCS scripts taking into account the running direction - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at bf98bf7: Container loaded wagons in Multiplayer mode
- Pull request #537 at 7d3db52: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at bf98bf7: Container loaded wagons in Multiplayer mode
- Pull request #537 at 939b2b2: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at bf98bf7: Container loaded wagons in Multiplayer mode
- Pull request #537 at 939b2b2: C# signal script extensions - Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at bf98bf7: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 3e4bc61: Upgrade libraries to netstandard 2.0 - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #694 at 4538fe6: Upgrade libraries to netstandard 2.0 - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 3f8380c: Renewed Russian translation up to testing T1.4-598 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at dda1a8a: Renewed Russian translation up to 1.5-rc1 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at b23557a: Renewed Russian translation up to 1.5-rc1 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting - Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #650 at 17a6be4: Renewed Russian translation up to 1.5-rc1 version - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #667 at aa5c629: Fix typo in Czech translation of menu - Pull request #677 at a1dc40b: Correct double heading bug - Pull request #678 at c19e718: Refactor TrainCar part 1 - Pull request #684 at 3f4cc62: fix: Clean up Data Validator help output to match dotnet-style - Pull request #685 at 203bbd2: fix: Clean up Data Converter help output to match dotnet-style - Pull request #686 at dab3e59: fix: Clean up Data Collector help output to match dotnet-style - Pull request #688 at e44897d: adds Help Icons to Video tab - Pull request #690 at 3399d4b: Sync turntables and transfertables in multiplayer mode - Pull request #691 at b2223e4: Removed lines in the RunActivity project file that are no longer used - Pull request #692 at c82a76d: Italian translation for OR 1.5 - Pull request #693 at 8162969: French locales - Pull request #695 at 237904d: Container loaded wagons in Multiplayer mode - Pull request #696 at b3735b0: Add check to prevent crashes when signal scripts use a bad draw state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi James,
Looked over this in detail (out of interest). Peter was also interested in your tidying of his code.
No problems seen.
Approved and merged with thanks,
Chris
…r-refactor-1 Refactor TrainCar part 1
Refactor TrainCar
Roadmap: https://trello.com/c/rA9gu11Q/526-refactor-traincar-to-simplify-inheritance
Discussion: http://www.elvastower.com/forums/index.php?/topic/36050-refactor-traincar-to-simplify-inheritance/
For the first refactoring I have chosen a couple of small parts: animated couplers and animated air hoses
Statistics
These statistics will be included with each refactoring part to demonstrate the improvements to the code (less code, same or more comments), which have been calculated using the
scc
(https://github.com/boyter/scc) toolSource/Orts.Parsers.Msts/STFReader.cs
Source/Orts.Simulation/Orts.Simulation.csproj
Source/Orts.Simulation/Simulation/Physics/Train.cs
Source/Orts.Simulation/Simulation/RollingStocks/Coupling/AnimatedAirHose.cs
Source/Orts.Simulation/Simulation/RollingStocks/Coupling/AnimatedCoupler.cs
Source/Orts.Simulation/Simulation/RollingStocks/MSTSWagon.cs
Source/Orts.Simulation/Simulation/RollingStocks/TrainCar.cs
Source/RunActivity/Viewer3D/RollingStock/MSTSWagonViewer.cs
Note
I am starting the PR with the
not-for-unstable
label because it will likely conflict with #569 until that one is merged