New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) #740
Merged
Sharpe49
merged 1 commit into
openrails:master
from
Sharpe49:feature/traction-cut-off-refactoring
Dec 11, 2022
+204
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpol
pushed a commit
that referenced
this pull request
Oct 26, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 65741c7: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at efbc397: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at 66095ac: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts)
twpol
pushed a commit
that referenced
this pull request
Oct 26, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 65741c7: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at efbc397: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at 66095ac: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode
…r to use the same design pattern as the C# signal scripts (compatible with current scripts)
Sharpe49
force-pushed
the
feature/traction-cut-off-refactoring
branch
from
October 26, 2022 07:32
66095ac
to
b3e66ca
Compare
twpol
pushed a commit
that referenced
this pull request
Oct 26, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 65741c7: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at efbc397: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode
twpol
pushed a commit
that referenced
this pull request
Oct 26, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 49c4ce8: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at efbc397: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode
twpol
pushed a commit
that referenced
this pull request
Oct 28, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at f9c7507: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at efbc397: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode
twpol
pushed a commit
that referenced
this pull request
Oct 29, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at f9c7507: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at efbc397: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode
twpol
pushed a commit
that referenced
this pull request
Oct 30, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 0aa8c34: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at efbc397: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode
twpol
pushed a commit
that referenced
this pull request
Oct 30, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 4c52f58: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at efbc397: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode
twpol
pushed a commit
that referenced
this pull request
Oct 30, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 4c52f58: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at efbc397: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #742 at 48c1ac2: Update of Russian Locales 'Oct 2022
twpol
pushed a commit
that referenced
this pull request
Oct 31, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 4c52f58: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #742 at 48c1ac2: Update of Russian Locales 'Oct 2022
twpol
pushed a commit
that referenced
this pull request
Nov 1, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 4c52f58: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #742 at 48c1ac2: Update of Russian Locales 'Oct 2022
cesarBLG
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any issues, waiting for blueprint approval
twpol
pushed a commit
that referenced
this pull request
Nov 6, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 4c52f58: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #742 at 48c1ac2: Update of Russian Locales 'Oct 2022 - Pull request #743 at 809cb6e: Default filename for include statements
twpol
pushed a commit
that referenced
this pull request
Nov 7, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 4c52f58: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #742 at 48c1ac2: Update of Russian Locales 'Oct 2022 - Pull request #743 at 809cb6e: Default filename for include statements - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state
twpol
pushed a commit
that referenced
this pull request
Nov 7, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 4c52f58: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #742 at 48c1ac2: Update of Russian Locales 'Oct 2022 - Pull request #743 at 60c8b99: Default filename for include statements - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state
twpol
pushed a commit
that referenced
this pull request
Nov 7, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 5a8da77: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #742 at 48c1ac2: Update of Russian Locales 'Oct 2022 - Pull request #743 at 60c8b99: Default filename for include statements - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state
twpol
pushed a commit
that referenced
this pull request
Nov 10, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 5a8da77: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 56d183c: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #743 at 60c8b99: Default filename for include statements - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #745 at cf5acd2: Fix digital displays in rear 3D cab
twpol
pushed a commit
that referenced
this pull request
Nov 12, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 5a8da77: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #743 at 60c8b99: Default filename for include statements - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #745 at cf5acd2: Fix digital displays in rear 3D cab
twpol
pushed a commit
that referenced
this pull request
Nov 12, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 5a8da77: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #743 at bdc6668: Default filename for include statements - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #745 at cf5acd2: Fix digital displays in rear 3D cab
twpol
pushed a commit
that referenced
this pull request
Nov 12, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 5a8da77: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #743 at bdc6668: Default filename for include statements - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #745 at cf5acd2: Fix digital displays in rear 3D cab - Pull request #746 at 0857d9b: Website release 1.5
twpol
pushed a commit
that referenced
this pull request
Nov 12, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 5a8da77: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #743 at 0292f16: Default filename for include statements - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #745 at cf5acd2: Fix digital displays in rear 3D cab - Pull request #746 at 0857d9b: Website release 1.5
twpol
pushed a commit
that referenced
this pull request
Nov 13, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 5a8da77: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #743 at c1801f4: Default filename for include statements - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #745 at cf5acd2: Fix digital displays in rear 3D cab - Pull request #746 at 0857d9b: Website release 1.5
twpol
pushed a commit
that referenced
this pull request
Nov 17, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at bc3a13b: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #745 at cf5acd2: Fix digital displays in rear 3D cab - Pull request #746 at 0857d9b: Website release 1.5
twpol
pushed a commit
that referenced
this pull request
Nov 19, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5
twpol
pushed a commit
that referenced
this pull request
Nov 20, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at 0858c49: OpenRailway Map
twpol
pushed a commit
that referenced
this pull request
Nov 21, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at a086ac7: OpenRailway Map
twpol
pushed a commit
that referenced
this pull request
Nov 21, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at 2220414: OpenRailway Map
twpol
pushed a commit
that referenced
this pull request
Nov 21, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at 7dab270: OpenRailway Map
twpol
pushed a commit
that referenced
this pull request
Nov 22, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map
twpol
pushed a commit
that referenced
this pull request
Nov 22, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.
twpol
pushed a commit
that referenced
this pull request
Nov 23, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.
twpol
pushed a commit
that referenced
this pull request
Nov 24, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #717 at 44fa8ad: Allow unlimited number of TCS cabview controls - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.
twpol
pushed a commit
that referenced
this pull request
Nov 24, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.
twpol
pushed a commit
that referenced
this pull request
Nov 27, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #735 at 3f1bc8c: Added new parameter for battery switch - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.
twpol
pushed a commit
that referenced
this pull request
Nov 27, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.
twpol
pushed a commit
that referenced
this pull request
Nov 28, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored. - Pull request #753 at ab8fe32: Extends CabControls for user input
twpol
pushed a commit
that referenced
this pull request
Nov 28, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 4609acb: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored. - Pull request #753 at ab8fe32: Extends CabControls for user input
twpol
pushed a commit
that referenced
this pull request
Dec 9, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 4609acb: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights
twpol
pushed a commit
that referenced
this pull request
Dec 11, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 4609acb: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #755 at 2fd409a: Bug fix for https://bugs.launchpad.net/or/+bug/1999330 Crash with a throttle-air combined control
twpol
pushed a commit
that referenced
this pull request
Dec 11, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 4609acb: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #755 at 2fd409a: Bug fix for https://bugs.launchpad.net/or/+bug/1999330 Crash with a throttle-air combined control - Pull request #756 at c3f5c55: Bug fix for https://bugs.launchpad.net/or/+bug/1999253 Night .dds textures not loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://blueprints.launchpad.net/or/+spec/scripts-refactoring