Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with a throttle-air combined control #755

Merged

Conversation

Csantucci
Copy link
Contributor

@Csantucci Csantucci commented Dec 11, 2022

@Csantucci Csantucci added the bug Something isn't working label Dec 11, 2022
@Csantucci Csantucci self-assigned this Dec 11, 2022
twpol pushed a commit that referenced this pull request Dec 11, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #706 at 570ab21: Extended door functionality
- Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries)
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
- Pull request #732 at 9cffa6d: Improvements for air brakes
- Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts)
- Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state
- Pull request #746 at 4609acb: Website release 1.5.1
- Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111
- Pull request #749 at db5764c: OpenRailway Map
- Pull request #753 at ab8fe32: Extends CabControls for user input
- Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights
- Pull request #755 at 2fd409a: Bug fix for https://bugs.launchpad.net/or/+bug/1999330 Crash with a throttle-air combined control
twpol pushed a commit that referenced this pull request Dec 11, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #706 at 570ab21: Extended door functionality
- Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries)
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
- Pull request #732 at 9cffa6d: Improvements for air brakes
- Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts)
- Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state
- Pull request #746 at 4609acb: Website release 1.5.1
- Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111
- Pull request #749 at db5764c: OpenRailway Map
- Pull request #753 at ab8fe32: Extends CabControls for user input
- Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights
- Pull request #755 at 2fd409a: Bug fix for https://bugs.launchpad.net/or/+bug/1999330 Crash with a throttle-air combined control
- Pull request #756 at c3f5c55: Bug fix for https://bugs.launchpad.net/or/+bug/1999253 Night .dds textures not loaded
Co-authored-by: César Benito Lamata <cesarbema2009@hotmail.com>
twpol pushed a commit that referenced this pull request Dec 11, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #706 at 570ab21: Extended door functionality
- Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries)
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
- Pull request #732 at 9cffa6d: Improvements for air brakes
- Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state
- Pull request #746 at 4609acb: Website release 1.5.1
- Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111
- Pull request #749 at db5764c: OpenRailway Map
- Pull request #753 at ab8fe32: Extends CabControls for user input
- Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights
- Pull request #755 at f79c1e2: Bug fix for https://bugs.launchpad.net/or/+bug/1999330 Crash with a throttle-air combined control
- Pull request #756 at c3f5c55: Bug fix for https://bugs.launchpad.net/or/+bug/1999253 Night .dds textures not loaded
twpol pushed a commit that referenced this pull request Dec 11, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #706 at 570ab21: Extended door functionality
- Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries)
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
- Pull request #738 at 88cadc9: Brake controller scripts refactoring and improvements for mouse control
- Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state
- Pull request #746 at 4609acb: Website release 1.5.1
- Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111
- Pull request #749 at db5764c: OpenRailway Map
- Pull request #753 at ab8fe32: Extends CabControls for user input
- Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights
- Pull request #755 at f79c1e2: Bug fix for https://bugs.launchpad.net/or/+bug/1999330 Crash with a throttle-air combined control
- Pull request #756 at c3f5c55: Bug fix for https://bugs.launchpad.net/or/+bug/1999253 Night .dds textures not loaded
Copy link
Contributor

@cesarBLG cesarBLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the quick correction

@Csantucci
Copy link
Contributor Author

Thanks for the fix and the quick correction

Thanks to you!

@Csantucci Csantucci merged commit 896573d into openrails:master Dec 11, 2022
@Csantucci Csantucci deleted the throttle-air-combined-control-fix branch December 11, 2022 21:04
@twpol twpol changed the title Bug fix for https://bugs.launchpad.net/or/+bug/1999330 Crash with a throttle-air combined control Crash with a throttle-air combined control Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants